Merge branch 'dev' into 1190-add-tests-for-job-generation-pipeline

Author: dhanur-sharma

.github/workflows/run_full_test_suite.yml

@@ -4,6 +4,8 @@ on:
   pull_request:
     branches:
       - dev
+    paths-ignore:
+      - '**/*.md'
 
 jobs:
   run-tests:

CHANGELOG.md

@@ -48,3 +48,26 @@ For each PR made, an entry should be added to this changelog. It should contain
   - Changes:
     - Added config_generation/tests/test_config_generation_pipeline.py which tests the config and job generation pipeline, ensuring all components interact correctly
     - config_generation/tests/test_db_to_xml.py is updated to include comprehensive tests for XML Processing
+
+- 1001-tests-for-critical-functionalities
+  - Description: Critical functionalities have been identified and listed, and critical areas lacking tests listed
+  - Changes:
+    - Integrated coverage.py as an indicative tool in the workflow for automated coverage reports on PRs, with separate display from test results.
+    - Introduced docs/architecture-decisions/testing_strategy.md, which includes the coverage report, lists critical areas, and specifically identifies those critical areas that are untested or under-tested.
+
+- 1192-finalize-the-infrastructure-for-frontend-testing
+  - Description: Set up comprehensive frontend testing infrastructure using Selenium WebDriver with Chrome, establishing a foundation for automated UI testing.
+  - Changes:
+    - Added Selenium testing dependency to `requirements/local.txt`
+    - Updated Dockerfile to support Chrome and ChromeDriver
+    - Created BaseTestCase and AuthenticationMixin for reusable test components
+    - Implemented core authentication test suite
+
+- 1195-implement-unit-test-for-forms-on-the-frontend
+  - Description: Implemented comprehensive frontend test suite covering authentication, collection management, search functionality, and pattern application forms.
+  - Changes:
+    - Added tests for authentication flows
+    - Implemented collection display and data table tests
+    - Added universal search functionality tests
+    - Created search pane filter tests
+    - Added pattern application form tests with validation checks

sde_collections/tests/frontend/test_pattern_application.py

@@ -141,6 +141,12 @@ def test_create_title_pattern(self):
         assert "3" in row_text
 
         self.driver.get(f"{self.live_server_url}/{self.collection.id}/delta-urls")
+
+        # Wait for at least one row to be present in the table
+        self.wait.until(
+            EC.presence_of_element_located((By.CSS_SELECTOR, "#delta_urls_table tbody tr td:not(.dt-empty)"))
+        )
+
         table_html = self.driver.find_element(By.ID, "delta_urls_table").get_attribute("outerHTML")
 
         # Verify that previous curated_url now appear in delta_urls page after pattern application

sde_indexing_helper/static/js/delta_url_list.js

@@ -1871,16 +1871,6 @@ function getCollectionId() {
   return collection_id;
 }
 
-function getParameterByName(name, url) {
-  if (!url) url = window.location.href;
-  name = name.replace(/[\[\]]/g, "\\$&");
-  var regex = new RegExp("[?&]" + name + "(=([^&#]*)|&|#|$)"),
-    results = regex.exec(url);
-  if (!results) return null;
-  if (!results[2]) return "";
-  return decodeURIComponent(results[2].replace(/\+/g, " "));
-}
-
 function remove_protocol(url) {
   return url.replace(/(^\w+:|^)\/\//, "");
 }