Skip to content

Commit d764dba

Browse files
authored
fix: Add wrapping div for scrollytelling map and chapters (#1437)
**Related Ticket:** Fix #1418 ### Description of Changes Since the legacy instance was using a lazyload-wrapper this wasn't necessary*, but for instances not using this approach, the additional wrapping div is actually required to build the layout as intended. It doesn't hurt the legacy either. \* The LazyLoad component from 'react-lazyload' creates a wrapping div with `class="lazyload-wrapper "` ### Validation / Testing Go to a story, make sure you can scroll down all the way to see text content below the scrollymap, as well as map comparison blocks. Corresponding deploy preview from next-veda-ui: https://deploy-preview-43--veda-ui-next-test.netlify.app/stories/air-quality-and-covid-19
2 parents f146f45 + f9aa2c7 commit d764dba

File tree

1 file changed

+2
-2
lines changed
  • app/scripts/components/common/blocks/scrollytelling

1 file changed

+2
-2
lines changed

app/scripts/components/common/blocks/scrollytelling/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ function Scrollytelling(props) {
358358
activeChapterLayerData ?? {};
359359

360360
return (
361-
<>
361+
<div>
362362
<ScrollyMapContainer topOffset={topOffset || 0}>
363363
{areLayersLoading && <MapLoading />}
364364

@@ -470,7 +470,7 @@ function Scrollytelling(props) {
470470
</Map>
471471
</ScrollyMapContainer>
472472
<TheChapters>{children}</TheChapters>
473-
</>
473+
</div>
474474
);
475475
}
476476

0 commit comments

Comments
 (0)