-
Notifications
You must be signed in to change notification settings - Fork 14
Description
#1922 introduced the embed mode for E&A.
Because of time constraints we merged it as-is, leaving open questions, documentation and file-organization improvements for follow-up work.
Questions:
How are users vs developers using this view?
The expectation is that they will review ghgc exploration in full view to get the view they need with the necessary datasets and then take the url with embed=true appended to use that view in another website.
This view should have a fully functional compare feature, but no timeline feature.
Or is the expectation that they will only see the embed/simple view only and they are NOT using this exploration view to generate a view to embed elsewhere? Or some other use case?
how are datasets selected if a user is not allowed to be in full view modehow can the embed/simple view be shared if it's within an iframe as the url won't change as the dates are modified (this is our assumption for how this is being used or is this being used as a typical e&a implementation)This is not an immediate concern
TODO / Questions
- fix such that embedExploration can be exported without issues with LayoutProps
- fix such that embedExploration does not include SPA header and footer
- fix tooltip on embed mode compare view
update update ghgc-ena next js instance to allow hiding header and footer, with clear documentation (we're unsure we need this embed mode in next-veda-ui)Not necessary because we completed above- rename embed mode to simple mode as that's more reflective of the view
remove extraneous time series components from embed/simple view?This is needed for comparefix compare components? (currently doesn't work. The date selector on the left isn't loading different tiles per date)This is needed and was caused by data being unavailable for the selected dataset- do we want to add a control/button to allow a user to switch to simple view (similar to world view)?
Previous todos below still apply:
In this ticket I propose we revisit the changes and confirm:
- All files include JSDoc comments that explain their functionality -- some of this may be completed here: docs: add JSDoc comments to E&A embed mode implementation #1931
- Filename and file structure updates related to the embed mode for better browsability (fix: embed mode follow on PR #1946)
Adding LayoutProps component breaks the downstram application (see fix: add missing export for embedded exploration #1933)