-
Notifications
You must be signed in to change notification settings - Fork 40
Open
Labels
Description
There are a few outstanding comments from #78 that are being moved to a new issue so that we can try to get the basic timeseries functionality merged in. Please see that PR for more details/context on these comments!
- From @wwieder , "I wonder if a more generic approach [than using
lev] may be to copy all the coordinate dimensions from a history file onto the single variable time series?" - Ensure code is generic enough for different history file types (e.g. patch or landunit level output from CLM, as opposed to grid cell averages)
-
vars_to_derivemight be updated when Sympy derived quantities from string equations ADF#278 comes in. From @nusbaume, "we could potentially use thesympypackage to allow users to write their own equations for derived variables without having to write new python code for each individual derived quantity." - from @TeaganKing, "Each component will need to adjust the variables they want to generate (unless processing all vars), the relevant history string, and the height dimension they are using (
levis currently the default) inconfig.yml. -
Process_allshould be updated; I think there's some issue going on with vars not being available in all files; this might have to do with needing to changehist_string. - We also want to include an alternative to
num_procsso that we don't surprise (especially non-NCAR) users with a somewhat hidden request for a particular number of processors - In order to manage which timeseries scripts we run (for which components), we can use the
compute_scriptsfeature. This will also allow us to specify that timeseries should be run first. For details, see comments from @rmshkv in API updates to specify components #88 and Add single-variable time series file generation function from ADF #78. @mnlevy1981 and I had also discussed including a--timeseries-onlyflag in order to run timeseries without running the notebooks, and renaming--timeseriesto--timeseries-firstto be clear that that particular flag is for running timeseries AND diagnostics notebooks. However, I think that the using thecompute_scriptsploomber capabilities would be ideal in this case. - Include
**timeseries_paramsand use something likeif type(arg1) == str: arg1 = [arg1]intimeseries.pyinstead ofrun.pyin order to implement kwargs. - hist_str list #90
- from @wwieder Can we include additional data for some components? For example having the information about
areaandlandfracmakes calculating global or regional sums easier.
Reactions are currently unavailable