Replies: 1 comment 2 replies
-
Technically I believe what we currently save1 includes all of the obs time-space points. This can lead to data being saved that aren't actually paired, e.g. due to differences in time ranges or spatial coverage. I think ideally the saved paired data should only include the useful paired points (time-space points that are non-null for both in the pair). But then the result of reading this is not exactly the same as the pairing result MM gives, currently at least. I think making the situation more clear in the docs sounds good and improving error messages. In principle, for Footnotes
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi all,
While working on a PR for arbitrary region selection and testing my code, I came across the following question, which I think merits discussion.
Currently, when we pair with point data, we save (sensibly, IMHO) only those points that are paired. This, however, has the following disadvantage: an.read_analysis() is not sufficient for all our plots. I.e., plots like the spatial_overlay() require reading also the model.
This is not necessarily a problem, it somehow makes sense that "paired_data" includes only those data that are effectively paired.
However, it leads to a difference between pairing with gridded data (i.e., satellite or, maybe in the future, pairing two models), where the paired.obj are self contained and we can do all plot just reading that in, and point/mobile data, where that is not the case, especially for maps. Right now, the fact that the model needs to be read again is not obvious in the docs nor in the examples.
I can think of 2 potential solutions:
@rschwant , @zmoon , @lkemmons what do you think?
Beta Was this translation helpful? Give feedback.
All reactions