forked from ESCOMP/CAM
-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
enhancementNew feature or requestNew feature or request
Description
What is the feature/what would you like to discuss?
I spent sometime going through the latest stormspeed branch and I saw a few places that we can either clean up the code or even remove some deprecated subroutines. For example:
- this loop seems empty without doing nothing, but it could be expensive since we are looping over all the indices (https://github.com/NCAR/StormSPEED/blob/stormspeed/src/dynamics/senh/restart_dynamics.F90#L255-L265).
- most contents of this file are commented out (https://github.com/NCAR/StormSPEED/blob/stormspeed/src/dynamics/senh/dycore_budget.F90). Can we remove this file?
- this subroutine is commented out (https://github.com/NCAR/StormSPEED/blob/stormspeed/src/dynamics/senh/interp_mod.F90#L550-L551). Does it mean that we don't need these subroutines now (https://github.com/NCAR/StormSPEED/blob/stormspeed/src/dynamics/senh/cam_mods/cube_mod_cam.F90#L21-L94)?
I think these cleanup work will make the code cleaner and hopefully avoid some unnecessary calculations.
Is there anyone in particular you want to be part of this conversation?
@jtruesdal @PeterHjortLauritzen
Will this change (regression test) answers?
No
Will you be implementing this enhancement yourself?
Any CAM SE can do this
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request