Skip to content

Commit 67769dd

Browse files
authored
updating to most recent musica version (#298)
* updating to most recent musica version * updating version in citation file * adding contributor
1 parent 8651deb commit 67769dd

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

CITATION.cff

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
cff-version: 1.2.0
22
message: If you use this software, please cite it as below.
33
title: MusicBox
4-
version: v2.5.5
4+
version: v2.6.0
55
authors:
66
- family-names: Dawson
77
given-names: Matthew
@@ -19,5 +19,7 @@ authors:
1919
given-names: Brendan
2020
- family-names: Drews
2121
given-names: Carl
22+
- family-names: Kiran
23+
given-names: Aditya
2224
license: Apache-2.0
2325
url: "https://github.com/NCAR/music-box"

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ classifiers = ["License :: OSI Approved :: Apache Software License"]
2121
dynamic = ["version", "description"]
2222

2323
dependencies = [
24-
"musica==0.8.1",
24+
"musica==0.9.0",
2525
"xarray",
2626
"colorlog",
2727
"pandas",

src/acom_music_box/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
This package contains modules for handling various aspects of a music box,
55
including species, products, reactants, reactions, and more.
66
"""
7-
__version__ = "2.5.5"
7+
__version__ = "2.6.0"
88

99
from .utils import convert_time, convert_pressure, convert_temperature, convert_concentration
1010
from .model_options import BoxModelOptions

src/acom_music_box/music_box.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,7 @@ def solve(self, callback=None):
154154
next_conditions = None
155155

156156
# calculate air density from the ideal gas law
157-
air_density = curr_conditions.pressure / \
158-
(GAS_CONSTANT * curr_conditions.temperature)
157+
air_density = curr_conditions.pressure / (GAS_CONSTANT * curr_conditions.temperature)
159158

160159
# outputs to output_array if enough time has elapsed
161160
if (next_output_time <= curr_time):
@@ -229,7 +228,7 @@ def loadJson(self, path_to_json):
229228
camp_path = os.path.join(os.path.dirname(path_to_json), self.config_file)
230229

231230
# Initalize the musica solver
232-
self.solver = musica.create_solver(camp_path, musica.micmsolver.rosenbrock, 1)
231+
self.solver = musica.create_solver(camp_path, musica.micmsolver.rosenbrock_standard_order, 1)
233232

234233
@staticmethod
235234
def order_reaction_rates(curr_conditions, rate_constant_ordering):

0 commit comments

Comments
 (0)