-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Milestone
Description
In #729, we added some C++ that correctly sets concentrations and conditions for all state types (vectorized, not vectorized). All of the index math is pulled into the music C++ layer, which made it quite easy to implement this in JavaScript.
However, in the Python and Fortran layers, we do have to do all of that vector math. We should refactor those layers to use the functionality added in #729.
Acceptance criteria
- The user-facing Python API remains the same, if possible
- The Python layer does not contain any indexing math to get/set concentration, conditions
- Any functions (like getting the concentration stride, vector size) used to do index math are removed in the python binding layer
- Fotran APIs are added which could allow us to take advantage of this new indexing interface
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels