Skip to content

Commit 1cde9f4

Browse files
committed
remove REVIEW comments
1 parent 45763fc commit 1cde9f4

File tree

7 files changed

+0
-19
lines changed

7 files changed

+0
-19
lines changed

cf/test/test_Data.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1479,7 +1479,6 @@ def test_Data__getitem__(self):
14791479
f = cf.Data([-999, 35], mask=[True, False]).reshape(2, 1)
14801480
self.assertTrue(e.equals(f))
14811481

1482-
# REVIEW: getitem: `test_Data__getitem__`: Chained subspaces reading from disk
14831482
# Chained subspaces reading from disk
14841483
f = cf.read(self.filename)[0]
14851484
d = f.data
@@ -3290,7 +3289,6 @@ def test_Data_rechunk(self):
32903289
self.assertEqual(e.chunks, ((4,), (5,)))
32913290
self.assertTrue(e.equals(d))
32923291

3293-
# REVIEW: getitem: `test_Data_rechunk`: rechunking after a __getitem__
32943292
# Test rechunking after a __getitem__
32953293
e = d[:2].rechunk((2, 5))
32963294
self.assertTrue(e.equals(d[:2]))
@@ -4520,7 +4518,6 @@ def test_Data__str__(self):
45204518
for element in elements0:
45214519
self.assertNotIn(element, d._get_cached_elements())
45224520

4523-
# REVIEW: getitem: `test_Data_cull_graph`: prevent new asanyarray layer
45244521
def test_Data_cull_graph(self):
45254522
"""Test `Data.cull`"""
45264523
# Note: The number of layers in the culled graphs include a
@@ -4779,7 +4776,6 @@ def test_Data_pad_missing(self):
47794776
with self.assertRaises(ValueError):
47804777
d.pad_missing(99, to_size=99)
47814778

4782-
# REVIEW: getitem: `test_Data_is_masked`: test `Data.is_masked`
47834779
def test_Data_is_masked(self):
47844780
"""Test Data.is_masked."""
47854781
d = cf.Data(np.arange(6).reshape(2, 3))

cf/test/test_Field.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1466,7 +1466,6 @@ def test_Field_indices(self):
14661466
shape = (1, 1, 1)
14671467

14681468
self.assertEqual(g.shape, shape)
1469-
# REVIEW: getitem: `test_Field_indices`: make sure works when 'g.array' is not masked
14701469
self.assertEqual(np.ma.compressed(g.array), 29)
14711470
if mode != "full":
14721471
self.assertEqual(g.construct("longitude").array, 83)
@@ -1485,7 +1484,6 @@ def test_Field_indices(self):
14851484
shape = (1, 2, 2)
14861485

14871486
self.assertEqual(g.shape, shape)
1488-
# REVIEW: getitem: `test_Field_indices`: make sure works when 'g.array' is not masked
14891487
self.assertTrue((np.ma.compressed(g.array) == [4, 29]).all())
14901488

14911489
# Add 2-d auxiliary coordinates with bounds, so we can

cf/test/test_FullArray.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# REVIEW: getitem: `test_FullArray`: new test module
21
import datetime
32
import faulthandler
43
import unittest

cf/test/test_NetCDF4Array.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
import cf
1414

15-
# REVIEW: h5: `test_NetCDF4Array.py`: renamed 'NetCDFArray' to 'NetCDF4Array'
1615
n_tmpfiles = 1
1716
tmpfiles = [
1817
tempfile.mkstemp("_test_NetCDF4Array.nc", dir=os.getcwd())[1]
@@ -41,7 +40,6 @@ class NetCDF4ArrayTest(unittest.TestCase):
4140
dtype=np.dtype(float),
4241
)
4342

44-
# REVIEW: h5: `test_NetCDF4Array`: renamed 'NetCDFArray' to 'NetCDF4Array'
4543
def test_NetCDF4Array_del_file_location(self):
4644
a = cf.NetCDF4Array(("/data1/file1", "/data2/file2"), ("tas1", "tas2"))
4745
b = a.del_file_location("/data1")
@@ -62,7 +60,6 @@ def test_NetCDF4Array_del_file_location(self):
6260
with self.assertRaises(ValueError):
6361
b.del_file_location("/data1/")
6462

65-
# REVIEW: h5: `test_NetCDF4Array`: renamed 'NetCDFArray' to 'NetCDF4Array'
6663
def test_NetCDF4Array_file_locations(self):
6764
a = cf.NetCDF4Array("/data1/file1")
6865
self.assertEqual(a.file_locations(), ("/data1",))
@@ -73,7 +70,6 @@ def test_NetCDF4Array_file_locations(self):
7370
a = cf.NetCDF4Array(("/data1/file1", "/data2/file2", "/data1/file2"))
7471
self.assertEqual(a.file_locations(), ("/data1", "/data2", "/data1"))
7572

76-
# REVIEW: h5: `test_NetCDF4Array`: renamed 'NetCDFArray' to 'NetCDF4Array'
7773
def test_NetCDF4Array_add_file_location(self):
7874
a = cf.NetCDF4Array("/data1/file1", "tas")
7975
b = a.add_file_location("/home/user")
@@ -109,15 +105,13 @@ def test_NetCDF4Array_add_file_location(self):
109105
self.assertEqual(b.get_filenames(), a.get_filenames())
110106
self.assertEqual(b.get_addresses(), a.get_addresses())
111107

112-
# REVIEW: h5: `test_NetCDF4Array`: renamed 'NetCDFArray' to 'NetCDF4Array'
113108
def test_NetCDF4Array__dask_tokenize__(self):
114109
a = cf.NetCDF4Array("/data1/file1", "tas", shape=(12, 2), mask=False)
115110
self.assertEqual(tokenize(a), tokenize(a.copy()))
116111

117112
b = cf.NetCDF4Array("/home/file2", "tas", shape=(12, 2))
118113
self.assertNotEqual(tokenize(a), tokenize(b))
119114

120-
# REVIEW: h5: `test_NetCDF4Array`: renamed 'NetCDFArray' to 'NetCDF4Array'
121115
def test_NetCDF4Array_multiple_files(self):
122116
f = cf.example_field(0)
123117
cf.write(f, tmpfile1)
@@ -135,7 +129,6 @@ def test_NetCDF4Array_multiple_files(self):
135129
self.assertEqual(len(n.get_filenames()), 2)
136130
self.assertTrue((n[...] == f.array).all())
137131

138-
# REVIEW: getitem: `test_NetCDF4Array`: test `NetCDF4Array.shape`
139132
def test_NetCDF4Array_shape(self):
140133
shape = (12, 73, 96)
141134
a = cf.NetCDF4Array("/home/file2", "tas", shape=shape)
@@ -145,7 +138,6 @@ def test_NetCDF4Array_shape(self):
145138
self.assertEqual(a.shape, (shape[0] // 2,) + shape[1:])
146139
self.assertEqual(a.original_shape, shape)
147140

148-
# REVIEW: getitem: `test_NetCDF4Array`: test `NetCDF4Array.index`
149141
def test_NetCDF4Array_index(self):
150142
shape = (12, 73, 96)
151143
a = cf.NetCDF4Array("/home/file2", "tas", shape=shape)

cf/test/test_active_storage.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# REVIEW: h5: `test_active_storage.py`: new test module
21
import atexit
32
import datetime
43
import faulthandler

cf/test/test_functions.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ def test_aliases(self):
4747
self.assertEqual(cf.tempdir(), cf.TEMPDIR())
4848
self.assertEqual(cf.chunksize(), cf.CHUNKSIZE())
4949

50-
# REVIEW: active: `test_configuration`: test `cf.active_storage`, cf.active_storage_url`, cf.active_storage_max_requests`
5150
def test_configuration(self):
5251
# This test assumes 'total_memory' remains constant throughout
5352
# the test run, which should be true generally in any

cf/test/test_read_write.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ def test_write_filename(self):
7979

8080
self.assertTrue((a == g[0].array).all())
8181

82-
# REVIEW: h5: `test_read_mask`: rename numpy to np
8382
def test_read_mask(self):
8483
f = self.f0.copy()
8584

@@ -561,7 +560,6 @@ def test_read_write_netCDF4_compress_shuffle(self):
561560
f"Bad read/write with lossless compression: {fmt}",
562561
)
563562

564-
# REVIEW: h5: `test_write_datatype`: rename numpy to np
565563
def test_write_datatype(self):
566564
f = cf.read(self.filename)[0]
567565
self.assertEqual(f.dtype, np.dtype(float))

0 commit comments

Comments
 (0)