Skip to content

Commit fb741f2

Browse files
authored
Merge pull request #826 from davidhassell/REVIEW
Remove REVIEW comments
2 parents c734c0c + ac981dd commit fb741f2

39 files changed

+0
-174
lines changed

cf/cfimplementation.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
)
2828
from .data import Data
2929

30-
# REVIEW: h5: `cfimplementation.py`: import `CFAH5netcdfArray`, `CFANetCDF4Array`, `H5netcdfArray`,`NetCDF4Array`
3130
from .data.array import (
3231
BoundsFromNodesArray,
3332
CellConnectivityArray,
@@ -116,7 +115,6 @@ def set_construct(self, parent, construct, axes=None, copy=True, **kwargs):
116115
parent, construct, axes=axes, copy=copy, **kwargs
117116
)
118117

119-
# REVIEW: h5: `initialise_CFANetCDF4Array`: new method to initialise `CFANetCDF4Array`
120118
def initialise_CFANetCDF4Array(self, **kwargs):
121119
"""Return a `CFANetCDF4Array` instance.
122120
@@ -133,7 +131,6 @@ def initialise_CFANetCDF4Array(self, **kwargs):
133131
cls = self.get_class("CFANetCDF4Array")
134132
return cls(**kwargs)
135133

136-
# REVIEW: h5: `initialise_CFAH5netcdfArray`: new method to initialise `CFAH5netcdfArray`
137134
def initialise_CFAH5netcdfArray(self, **kwargs):
138135
"""Return a `CFAH5netcdfArray` instance.
139136

cf/constants.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
"LOG_LEVEL": logging.getLevelName(logging.getLogger().level),
6464
"BOUNDS_COMBINATION_MODE": "AND",
6565
"CHUNKSIZE": parse_bytes(_CHUNKSIZE),
66-
# REVIEW: active: `CONSTANTS`: new constants 'active_storage', 'active_storage_url', 'active_storage_max_requests'
6766
"active_storage": False,
6867
"active_storage_url": None,
6968
"active_storage_max_requests": 100,

cf/data/array/__init__.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,11 @@
11
from .boundsfromnodesarray import BoundsFromNodesArray
22
from .cellconnectivityarray import CellConnectivityArray
3-
4-
# REVIEW: h5: `__init__.py`: import `CFAH5netcdfArray`
53
from .cfah5netcdfarray import CFAH5netcdfArray
6-
7-
# REVIEW: h5: `__init__.py`: import `CFAH5netcdfArray`
84
from .cfanetcdf4array import CFANetCDF4Array
95
from .fullarray import FullArray
106
from .gatheredarray import GatheredArray
11-
12-
# REVIEW: h5: `__init__.py`: import `H5netcdfArray`
137
from .h5netcdfarray import H5netcdfArray
148
from .netcdfarray import NetCDFArray
15-
16-
# REVIEW: h5: `__init__.py`: import `NetCDF4Array`
179
from .netcdf4array import NetCDF4Array
1810
from .pointtopologyarray import PointTopologyArray
1911
from .raggedcontiguousarray import RaggedContiguousArray

cf/data/array/cfah5netcdfarray.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# REVIEW: h5: `CFAH5netcdfArray`: New class for accessing CFA with `h5netcdf`
21
from .h5netcdfarray import H5netcdfArray
32
from .mixin import CFAMixin
43

cf/data/array/cfanetcdf4array.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# REVIEW: h5: `CFAnetCDF4Array`: New class for accessing CFA with `netCDF4`
21
from .mixin import CFAMixin
32
from .netcdf4array import NetCDF4Array
43

cf/data/array/fullarray.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ class FullArray(IndexMixin, Array):
1616
1717
"""
1818

19-
# REVIEW: h5: `__init__`: replace units/calendar API with attributes
2019
def __init__(
2120
self,
2221
fill_value=None,
@@ -121,7 +120,6 @@ def __str__(self):
121120

122121
return f"Filled with {fill_value!r}"
123122

124-
# REVIEW: getitem: `_get_array`: new method to convert subspace to numpy array
125123
def _get_array(self, index=None):
126124
"""Returns the full array.
127125
@@ -156,7 +154,6 @@ def _get_array(self, index=None):
156154

157155
return array
158156

159-
# REVIEW: getitem: `array`: New property to convert subspace to numpy array
160157
@property
161158
def array(self):
162159
"""Return an independent numpy array containing the data.

cf/data/array/h5netcdfarray.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# REVIEW: h5: `H5netcdfArray`: New class to access netCDF with `h5netcdf`
21
import cfdm
32

43
from ...mixin_container import Container
@@ -49,8 +48,6 @@ def _lock(self):
4948
"""
5049
return netcdf_lock
5150

52-
# REVIEW: h5: `_get_array`: Ignore this for h5 review
53-
# REVIEW: getitem: `_get_array`: new method to convert subspace to numpy array.
5451
def _get_array(self, index=None):
5552
"""Returns a subspace of the dataset variable.
5653

cf/data/array/locks.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# REVIEW: h5: `locks.py`: New module to provide file locks
21
from dask.utils import SerializableLock
32

43
# Global lock for netCDF file access

cf/data/array/mixin/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
# REVIEW: active: `__init__.py`: import `ActiveStorageMixin`
21
from .activestoragemixin import ActiveStorageMixin
32
from .arraymixin import ArrayMixin
43
from .cfamixin import CFAMixin
54
from .compressedarraymixin import CompressedArrayMixin
65
from .filearraymixin import FileArrayMixin
7-
8-
# REVIEW: getitem: `__init__.py`: import `IndexMixin`
96
from .indexmixin import IndexMixin

cf/data/array/mixin/activestoragemixin.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
# REVIEW: active: `ActiveStorageMixin`: new mixin class `ActiveStorageMixin`
2-
3-
41
class ActiveStorageMixin:
52
"""Mixin class for enabling active storage operations.
63

0 commit comments

Comments
 (0)