Change add_other_entities to set_other_entities

I think this makes the intent more clear.

Author: amoeba

NAMESPACE

@@ -4,7 +4,6 @@ export(add_access_rules)
 export(add_additional_identifiers)
 export(add_admin_group_access)
 export(add_methods_step)
-export(add_other_entities)
 export(add_string_to_title)
 export(change_eml_name)
 export(clear_methods)
@@ -76,6 +75,7 @@ export(replace_package_id)
 export(replace_subject)
 export(set_access)
 export(set_file_name)
+export(set_other_entities)
 export(set_public_read)
 export(set_rights_and_access)
 export(set_rights_holder)

R/editing.R

@@ -322,13 +322,13 @@ publish_update <- function(mn,
   }
 
   # Write out the document to disk. We do this in part because
-  # add_other_entities takes a path to the doc.
+  # set_other_entities takes a path to the doc.
   eml_path <- tempfile()
   EML::write_eml(eml, eml_path)
 
   # Add other entity fields (if appropriate)
   if (!is.null(data_pids) && !skip_other_entities) {
-    eml <- add_other_entities(mn, eml_path, data_pids)
+    eml <- set_other_entities(mn, eml_path, data_pids)
   }
 
   if (skip_other_entities) {

R/eml.R

@@ -94,7 +94,7 @@ sysmeta_to_entity <- function(sysmeta) {
 }
 
 
-#' Creates and adds EML otherEntity elements to an existing EML document.
+#' Creates and sets EML otherEntity elements to an existing EML document.
 #'
 #' This function isn't that smart. It will remove existing otherEntity elements
 #' if what's in their 'id' attribute isn't `pids`. It will then go on to add
@@ -112,7 +112,7 @@ sysmeta_to_entity <- function(sysmeta) {
 #' @export
 #'
 #' @examples
-add_other_entities <- function(mn, path, pids) {
+set_other_entities <- function(mn, path, pids) {
   stopifnot(class(mn) == "MNode")
   stopifnot(file.exists(path))
   stopifnot(all(is.character(pids)),
@@ -127,7 +127,7 @@ add_other_entities <- function(mn, path, pids) {
   doc <- EML::read_eml(path)
   stopifnot(class(doc) == "eml")
 
-  message("Adding EML otherEntity elements...")
+  message("Setting EML otherEntity elements. This can take a while if there are lots of PIDs...")
 
   current_entity_pids <- vapply(doc@dataset@otherEntity, function(x) x@id, "", USE.NAMES = FALSE)
 

R/helpers.R

@@ -21,7 +21,7 @@ create_dummy_metadata <- function(mn, data_pids=NULL) {
 
   # Add otherEntity elements if needed
   if (!is.null(data_pids)) {
-    metadata_file <- add_other_entities(mn, metadata_file, data_pids)
+    metadata_file <- set_other_entities(mn, metadata_file, data_pids)
   }
 
   sysmeta <- new("SystemMetadata",