-
-
Notifications
You must be signed in to change notification settings - Fork 26
Description
The App Model is not creating a valid ORCID search URL, which causes all orcid searches via LookupModel.orcidSearch to fail.
The app model sets up the url like so:
if (this.get("orcidBaseUrl")) {
this.set(
"orcidSearchUrl",
this.get("orcidBaseUrl") + "/v1.1/search/orcid-bio?q=",
);
}then elsewhere overwrites it to
if (typeof this.get("orcidBaseUrl") != "undefined")
this.set(
"orcidSearchUrl",
this.get("orcidBaseUrl") + "/search/orcid-bio?q=",
);Neither work. Version 1.1 was deprecated in 2018. Requests to https://orcid.org/search/orcid-bio? return a 302 and no results. orcid is on version 3, which uses the url format: https://pub.orcid.org/v3.0/search/?q=.
We should update the URLs and test to make sure everything works as expected. We should also check whether there are request limits to the v3 api.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
In Review