Fix merging of 'icinga2_objects' (#413)

`icinga2_objects` might be a dict or a list. Merging will happen at a
specific point during execution.
Feature objects are now merged with `tmp_objects` to avoid problems.

Author: Donien

roles/icinga2/tasks/configure.yml

@@ -78,6 +78,7 @@
   changed_when: _removed_dirs.attempts > 1
 
 - name: Collect config files (icinga2_config_path)
+  when: icinga2_config_directories is defined
   vars:
     _icinga2_config_directories: "{{
       (icinga2_config_directories | select('match', '^conf.d/.*')) +
@@ -96,13 +97,15 @@
   vars:
     _icinga2_sys_config_fragment_path: "{{ item | regex_replace('^' + icinga2_config_path + '(.*)$', icinga2_fragments_path + '\\1') }}"
   when:
+    - icinga2_config_directories is defined
     - _icinga2_sys_config_fragment_path not in icinga2_local_objects
     - _icinga2_sys_config_fragment_path not in _icinga2_custom_conf_paths
   ansible.builtin.file:
     state: absent
     dest: "{{ item }}"
 
 - name: Remove empty config dirs (icinga2_config_path) # noqa: command-instead-of-shell
+  when: icinga2_config_directories is defined
   vars:
     _icinga2_config_directories: "{{
       (

roles/icinga2/tasks/features/api.yml

@@ -30,7 +30,7 @@
 
 - name: feature api ApiListener object
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - name: api
@@ -40,7 +40,7 @@
 
 - name: feature api Endpoint objects
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - type: Endpoint
@@ -52,7 +52,7 @@
 
 - name: feature api Zone objects
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - type: Zone

roles/icinga2/tasks/features/checker.yml

@@ -2,7 +2,7 @@
 
 - name: feature checker CheckerComponent object
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - name: checker

roles/icinga2/tasks/features/command.yml

@@ -2,7 +2,7 @@
 
 - name: feature command ExternalCommandListener object
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - name: command

roles/icinga2/tasks/features/compatlog.yml

@@ -2,7 +2,7 @@
 
 - name: Feature compatlog CompatLogger object
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - name: compatlog

roles/icinga2/tasks/features/debuglog.yml

@@ -2,7 +2,7 @@
 
 - name: feature debuglog FileLogger object
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - name: debug-file

roles/icinga2/tasks/features/elasticsearch.yml

@@ -2,7 +2,7 @@
 
 - name: feature elasticsearch ElasticsearchWriter object
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - name: elasticsearch

roles/icinga2/tasks/features/gelf.yml

@@ -2,7 +2,7 @@
 
 - name: feature influxdb GelfWriter object
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - name: gelf

roles/icinga2/tasks/features/graphite.yml

@@ -2,7 +2,7 @@
 
 - name: feature graphite GraphiteWriter object
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - name: graphite

roles/icinga2/tasks/features/icingadb.yml

@@ -2,7 +2,7 @@
 
 - name: feature icingadb IcingaDB object
   ansible.builtin.set_fact:
-    icinga2_objects: "{{ icinga2_objects + objects }}"
+    tmp_objects: "{{ tmp_objects | default([]) + objects }}"
   vars:
     objects:
       - name: icingadb