Change order of tasks when dealing with modules

[mocdaniel]

In some cases, icingacli tries to call modules that haven't been enabled at that point. This leads to errors, e.g. when disabling and enabling modules in two consecutive runs.

Since enabling modules is nothing more than setting a symlink, we could shift this task towards the start of the role's routine.

[schneif2]

When director get´s disabled:

TASK [icinga.icinga.icingaweb2 : Manage enabled/disabled modules] **************
ok: [de-szr-ici-web] => (item={'key': 'icingadb', 'value': {'source': 'package', 'enabled': True, 'config': {'icingadb': {'resource': 'icinga_db'}, 'redis': {'tls': 0}}, 'redis': {'redis1': {'host': 'de-szr-ici-db1.de.hydac.int', 'port': 6380, 'password': '[MASKED]'}, 'redis2': {'host': 'de-szr-ici-db2.de.hydac.int', 'port': 6380, 'password': '[MASKED]'}}, 'commandtransports': {'icinga-co1': {'port': 5665, 'transport': 'api', 'host': 'de-szr-ici-co1.de.hydac.int', 'username': 'icingaweb2', 'password': '[MASKED]'}, 'icinga-co2': {'port': 5665, 'transport': 'api', 'host': 'de-szr-ici-co2.de.hydac.int', 'username': 'icingaweb2', 'password': '[MASKED]'}}}})
--- before
+++ after
@@ -1,2 +1,2 @@
 path: /etc/icingaweb2/enabledModules/director
-state: link
+state: absent
changed: [de-szr-ici-web] => (item={'key': 'director', 'value': {'enabled': False, 'source': 'package', 'import_schema': True, 'run_kickstart': True, 'kickstart': {'config': {'endpoint': 'de-szr-ici-co1.de.hydac.int', 'username': 'director', 'password': '[MASKED]'}}, 'config': {'db': {'resource': 'director_db'}}}})

When director get´s reinabled:

TASK [icinga.icinga.icingaweb2 : Module Director | Check if kickstart is required] ***
fatal: [de-szr-ici-web]: FAILED! => changed=false 
  cmd: icingacli director kickstart required
  delta: '0:00:00.041895'
  end: '2023-10-31 17:53:23.614831'
  failed_when_result: true
  msg: non-zero return code
  rc: 3
  start: '2023-10-31 17:53:23.572936'
  stderr: |-
    ERROR: There is no such module or command: 'director'
  
    USAGE: icingacli [module] <command> [action] [options]
  
    Available commands:
  
      help            Help for modules, commands and actions
      module          List and handle modules
      version         Shows version of Icinga Web 2, loaded modules and PHP
      web
  
    Available modules:
  
      icingadb
      incubator
  
    Global options:
  
      --log [t]       Log to <t>, either stderr, file or syslog (default: stderr)
      --log-path <f>  Which file to log into in case of --log file
      --verbose       Be verbose
      --debug         Show debug output
      --help          Show help
      --benchmark     Show benchmark summary
      --watch [s]     Refresh output every <s> seconds (default: 5)
      --version       Shows version of Icinga Web 2, loaded modules and PHP
  
    Show help on a specific command : icingacli help <command>
    Show help on a specific module  : icingacli help <module>
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>

[mkayontour]

As it is always stated in the documention, we can switch up the order here. Normally the installation process on modules is, install, enable, configure over web. So we can easily enable the modules beforehand.

When disabled it should only disable the module at first and then skip the whole configuration process.