Debug: benchmark SNMP session related operations

Author: Al2Klimov

snmp_bulkget.c

@@ -95,8 +95,14 @@ unsigned int uptime = 0, sleep_usecs = 0;
 unsigned int lastcheck = 0;
 unsigned long global_timeout = DFLT_TIMEOUT;
 
+static
 int ifNumber = 0;
 
+#ifdef DEBUG
+static
+char *implode_result;
+#endif
+
 int
 main(int argc, char *argv[])
 {
@@ -374,11 +380,17 @@ main(int argc, char *argv[])
     if (getenv("MIBS") == NULL)
         setenv("MIBS", "", 1);
 
+#ifdef DEBUG
+    benchmark_start("Start SNMP session");
+#endif
     if (user)
         /* use snmpv3 */
         ss=start_session_v3(&session, user, auth_proto, auth_pass, priv_proto, priv_pass, hostname);
     else
         ss=start_session(&session, community, hostname);
+#ifdef DEBUG
+    benchmark_end();
+#endif
 
     if (mode == NONBULK) {
         oid_ifp = oid_if_get;
@@ -428,8 +440,16 @@ main(int argc, char *argv[])
             snmp_add_null_var(pdu, lastOid.name, lastOid.name_len);
         }
 
+#ifdef DEBUG
+        implode_result = implode(", ", oid_ifp + count);
+        benchmark_start("Send SNMP request for OIDs: %s", implode_result);
+#endif
         /* send the request */
         status = snmp_synch_response(ss, pdu, &response);
+#ifdef DEBUG
+        benchmark_end();
+        free(implode_result);
+#endif
         if (sleep_usecs)
             usleep(sleep_usecs);
 
@@ -596,8 +616,16 @@ main(int argc, char *argv[])
                 snmp_add_null_var(pdu, lastOid.name, lastOid.name_len);
             }
 
+#ifdef DEBUG
+            implode_result = implode(", ", oid_aliasp + count);
+            benchmark_start("Send SNMP request for OIDs: %s", implode_result);
+#endif
             /* send the request */
             status = snmp_synch_response(ss, pdu, &response);
+#ifdef DEBUG
+            benchmark_end();
+            free(implode_result);
+#endif
             if (sleep_usecs) usleep(sleep_usecs);
 
             if (status == STAT_SUCCESS && response->errstat == SNMP_ERR_NOERROR) {
@@ -1068,7 +1096,13 @@ main(int argc, char *argv[])
     }
     printf("\n%*s", (int)perf.len, perf.text);
 
+#ifdef DEBUG
+    benchmark_start("Close SNMP session");
+#endif
     snmp_close(ss);
+#ifdef DEBUG
+    benchmark_end();
+#endif
 
     SOCK_CLEANUP;
     return ((errorflag)?2:((warnflag)?1:0));
@@ -1448,7 +1482,15 @@ int create_request(netsnmp_session *ss, struct OIDStruct **OIDpp, char **oid_lis
 
     *OIDpp = OIDp;
 
+#ifdef DEBUG
+    implode_result = implode(", ", oid_list);
+    benchmark_start("Send SNMP request for OIDs: %s", implode_result);
+#endif
     status = snmp_synch_response(ss, pdu, response);
+#ifdef DEBUG
+    benchmark_end();
+    free(implode_result);
+#endif
     if (sleep_usecs) usleep(sleep_usecs);
 
     if (status == STAT_SUCCESS && (*response)->errstat == SNMP_ERR_NOERROR) {

utils.c

@@ -1,3 +1,9 @@
+#include <stdarg.h>
+#include <stddef.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <time.h>
 #include "utils.h"
 
 /*
@@ -113,3 +119,84 @@ int gauge_to_si(u64 bignum, char **str)
 
 }
 
+static
+struct timespec benchmark_start_time;
+
+static
+char *benchmark_task;
+
+void benchmark_start(char const *format, ...)
+{
+    {
+        va_list args;
+        va_start(args, format);
+        int benchmark_task_length = vsnprintf(NULL, 0u, format, args);
+        va_end(args);
+        benchmark_task = (char*)malloc(benchmark_task_length + 1);
+        benchmark_task[benchmark_task_length] = 0;
+    }
+    {
+        va_list args;
+        va_start(args, format);
+        vsprintf(benchmark_task, format, args);
+        va_end(args);
+    }
+    fprintf(stderr, "[Starting benchmark] %s\n", benchmark_task);
+    clock_gettime(CLOCK_MONOTONIC, &benchmark_start_time);
+}
+
+void benchmark_end(void)
+{
+    {
+        struct timespec benchmark_end_time;
+        clock_gettime(CLOCK_MONOTONIC, &benchmark_end_time);
+        fprintf(
+            stderr,
+            "[Finished benchmark after %f ms] %s\n",
+            ((double)benchmark_end_time.tv_sec * 1000.0 + (double)benchmark_end_time.tv_nsec / 1000000.0)
+            - ((double)benchmark_start_time.tv_sec * 1000.0 + (double)benchmark_start_time.tv_nsec / 1000000.0),
+            benchmark_task
+        );
+    }
+    free(benchmark_task);
+}
+
+char *implode(char const *glue, char **pieces)
+{
+    size_t total_len = 0u;
+    char **walk_pieces = pieces;
+    while (*walk_pieces != NULL) {
+        total_len += strlen(*walk_pieces++);
+    }
+
+    ptrdiff_t walk_pieces_diff = walk_pieces - pieces;
+    if (walk_pieces_diff >= 2) {
+        total_len += strlen(glue) * (size_t)(walk_pieces_diff - 1);
+    }
+
+    char *result = (char*)malloc(total_len + 1u);
+
+    if (walk_pieces_diff > 0) {
+        strcpy(result, *pieces);
+        if (walk_pieces_diff >= 2) {
+            char *walk_result = result;
+            walk_pieces = pieces + 1;
+            while (*walk_pieces != NULL) {
+                while (*walk_result) {
+                    ++walk_result;
+                }
+                strcpy(walk_result, glue);
+
+                while (*walk_result) {
+                    ++walk_result;
+                }
+                strcpy(walk_result, *walk_pieces++);
+            }
+        }
+    } else {
+        *result = 0;
+    }
+
+    return result;
+}
+

utils.h

@@ -28,3 +28,6 @@ int addstrold(char **, size_t *, const char *, ...);
 int addstr(String *, const char *, ...);
 void strcpy_nospaces(char *, char *);
 int gauge_to_si(u64, char **);
+void benchmark_start(char const *, ...);
+void benchmark_end(void);
+char *implode(char const *, char **);