Merge pull request #28 from NETWAYS/dependabot/github_actions/golangci/golangci-lint-action-7

Bump golangci/golangci-lint-action from 6 to 7

Author: RincewindsHat

.github/workflows/golangci-lint.yml

@@ -16,6 +16,6 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.54
+          version: v2.0.2

.golangci.yml

@@ -1,50 +1,58 @@
+version: "2"
 run:
-  timeout: 5m
   tests: false
-  skip-files:
-    - 'testhelper/for_main.go'
-issues:
-  exclude-rules:
-    - path: 'result/overall.go'
-      linters:
-        - nestif
-    - path: 'convert/bytes_common.go'
-      linters:
-        - ireturn
-    - path: 'CheckCommandArgument.go'
-      linters:
-        - goconst
 linters:
-   enable-all: true
-   disable:
-     - cyclop
-     - depguard
-     - exhaustivestruct
-     - exhaustruct
-     - forbidigo
-     - forcetypeassert
-     - gci
-     - gochecknoglobals
-     - gochecknoinits
-     - godox
-     - godot
-     - goerr113
-     - gofumpt
-     - gomnd
-     - lll
-     - musttag
-     - nakedret
-     - nlreturn
-     - nolintlint
-     - nonamedreturns
-     - tagliatelle
-     - varnamelen
-     - wrapcheck
-linters-settings:
-   estif:
-     min-complexity: 4
-   maligned:
-     suggest-new: true
-   funlen:
-     ignore-comments: true
-     lines: 75
+  default: all
+  disable:
+    - funlen
+    - cyclop
+    - depguard
+    - err113
+    - exhaustruct
+    - forbidigo
+    - forcetypeassert
+    - gochecknoglobals
+    - gochecknoinits
+    - godot
+    - godox
+    - lll
+    - mnd
+    - musttag
+    - nakedret
+    - nlreturn
+    - nolintlint
+    - nonamedreturns
+    - tagliatelle
+    - varnamelen
+    - wrapcheck
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - nestif
+        path: result/overall.go
+      - linters:
+          - ireturn
+        path: convert/bytes_common.go
+      - linters:
+          - goconst
+        path: CheckCommandArgument.go
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

CheckCommand.go

@@ -30,6 +30,7 @@ func (cc *CheckCommand) String() string {
 	bla.WriteString(indentString() + "command = " + cc.Command.String() + "\n")
 
 	bla.WriteString(indentString() + "arguments = {\n")
+
 	indentation++
 
 	for i := range cc.Arguments {

go.mod

@@ -1,3 +1,3 @@
 module github.com/NETWAYS/go-icingadsl
 
-go 1.21
+go 1.22

types.go

@@ -106,9 +106,10 @@ func (ia *Array) String() string {
 	b.WriteString("[")
 
 	if len(*ia) > 1 {
-		for i := 0; i < len(*ia)-1; i++ {
+		for i := range len(*ia) - 1 {
 			b.WriteString((*ia)[i].String() + ", ")
 		}
+
 		b.WriteString((*ia)[len(*ia)-1].String())
 	} else if len(*ia) == 1 {
 		b.WriteString((*ia)[0].String())

types_test.go

@@ -5,7 +5,7 @@ import (
 	"time"
 )
 
-func assertEqualString(t *testing.T, actual, expected string) {
+func assertEqualString(t *testing.T, expected, actual string) {
 	if actual != expected {
 		t.Error("\nActual: ", actual, "\nExpected: ", expected)
 	}