Merge pull request #183 from NFFT/feature/collect-core-dumps

Feature/collect core dumps

Author: jenskeiner

.github/workflows/build-linux.yml

@@ -67,6 +67,15 @@ jobs:
     steps:    
     - uses: actions/checkout@v5
 
+    - name: Enable core dumps
+      run: |
+        ulimit -c unlimited
+        sudo mkdir /cores
+        sudo chmod 777 /cores
+        # Core filenames will be of the form executable.pid.timestamp:
+        sudo bash -c 'echo "/cores/%e.%p.%t" > /proc/sys/kernel/core_pattern'
+        echo "Core dumps will be written to: /cores"
+
     - name: Disable initramfs update
       run: sudo sed -i 's/yes/no/g' /etc/initramfs-tools/update-initramfs.conf
 
@@ -194,13 +203,13 @@ jobs:
       run: make check
 
     - name: Run tests again to reproduce failure
-      if: steps.test.outcome == 'failure'
+      if: failure() && steps.test.conclusion == 'failure'
       run: |
         tests/checkall > checkall.log
         if [ "${{ matrix.openmp }}" = "1" ]; then tests/checkall_threads > checkall_threads.log; fi
 
     - name: Upload test failure logs
-      if: steps.test.outcome == 'failure'
+      if: failure() && steps.test.conclusion == 'failure'
       uses: actions/upload-artifact@v5
       with:
         name: test-failure-logs-${{ env.BUILD_CONFIG }}
@@ -241,6 +250,50 @@ jobs:
           cd ../..
         done
 
+    - name: Collect core dumps and binaries
+      if: failure()
+      run: |
+        # Extract binary paths from core dumps and copy them
+        for corefile in /cores/*.*.*; do
+          if [ -f "$corefile" ]; then
+            echo "Processing $corefile"
+            
+            # Get the binary path from the core dump
+            binary=$(file "$corefile" | grep -oP "from '[^']*'" | cut -d"'" -f2)
+            
+            # Alternative method using gdb (more reliable)
+            if command -v gdb &> /dev/null; then
+              binary=$(gdb -quiet -batch -c "$corefile" 2>/dev/null | grep "Core was generated by" | sed "s/Core was generated by \`\(.*\)'.*/\1/" | awk '{print $1}')
+            fi
+            
+            echo "Binary: $binary"
+            
+            # Copy the binary if it exists
+            if [ -n "$binary" ] && [ -f "$binary" ]; then
+              cp "$binary" /cores/
+              echo "Copied binary: $binary"
+              
+              # Also copy any shared libraries if needed
+              ldd "$binary" 2>/dev/null | grep "=>" | awk '{print $3}' | while read lib; do
+                if [ -f "$lib" ]; then
+                  cp --parents "$lib" /cores/ 2>/dev/null || true
+                fi
+              done
+            fi
+          fi
+        done
+        
+        ls -lah /cores/
+
+    - name: Upload core dumps
+      if: failure()
+      uses: actions/upload-artifact@v4
+      with:
+        name: coredumps-${{ github.run_id }}
+        path: /cores/
+        if-no-files-found: warn
+        retention-days: 7
+
     - name: Publish Test Report
       uses: ctrf-io/github-test-reporter@v1
       with:

tests/nfft.c

@@ -234,7 +234,7 @@ static R err_trafo(X(plan) *p)
     b = K(50.0);
   #elif MANT_DIG == 64
     // Intel double extended, 80 bits.
-    a = K(0.8);
+    a = K(0.815);
     b = K(50.0);
   #elif MANT_DIG == 53
     // IEEE 754 double precision, 64 bits.