-
Notifications
You must be signed in to change notification settings - Fork 106
Open
Description
@JessicaNeedham and I stumbled upon this bug in the damage code yesterday:
https://github.com/NGEET/fates/blob/main/biogeochem/EDPhysiologyMod.F90#L294-L295
There is a call to "cycle", however if you cycle inside a linked list loop, you wont advance unless you advance to the next cohort before triggering the cycle.
This probably has not given anyone trouble yet because we haven't done too much work with damage and non-woody plants, and this seems to have been buffered from encountering new plants.
Simple fix:
if(prt_params%woody(ccohort%pft)==ifalse .or. ccohort%isnew ) then
ccohort => ccohort%shorter
cycle
end
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels