Fix crash when user connects to rssh client, then closes their entire session, add recover to ensure all command handlers cannot crash server, closes #196

Author: NHAS

internal/server/commands/connect.go

@@ -184,7 +184,12 @@ func attachSession(newSession ssh.Channel, currentClientSession io.ReadWriter, c
 RequestsProxyPasser:
 	for {
 		select {
-		case r := <-currentClientRequests:
+		case r, ok := <-currentClientRequests:
+			if !ok || r == nil {
+				// user has disconnected
+				return nil
+			}
+
 			response, err := internal.SendRequest(*r, newSession)
 			if err != nil {
 				break RequestsProxyPasser

internal/server/handlers/session.go

@@ -4,6 +4,7 @@ import (
 	"encoding/binary"
 	"fmt"
 	"io"
+	"runtime/debug"
 
 	"github.com/NHAS/reverse_ssh/internal"
 	"github.com/NHAS/reverse_ssh/internal/server/commands"
@@ -47,6 +48,13 @@ func Session(datadir string) ChannelHandler {
 		}
 		defer connection.Close()
 
+		defer func() {
+			if r := recover(); r != nil {
+				fmt.Println("Recovered a panic:", r)
+				debug.PrintStack()
+			}
+		}()
+
 		sess.ShellRequests = requests
 
 		for req := range requests {

internal/terminal/terminal.go

@@ -203,6 +203,7 @@ func (t *Terminal) handleWindowSize() {
 				return
 			case req := <-t.session.ShellRequests:
 				if req == nil { // Channel has closed, so therefore end this default handler
+
 					return
 				}