NRL-703 switch to bool arg instead

Author: eesa456

api/producer/upsertDocumentReference/upsert_document_reference.py

@@ -108,6 +108,9 @@ def handler(
 
     if result.resource.relatesTo:
         logger.log(LogReference.PROUPSERT006, relatesTo=result.resource.relatesTo)
+        can_ignore_delete_fail = (
+            PERMISSION_SUPERSEDE_IGNORE_DELETE_FAIL in metadata.nrl_permissions
+        )
 
         for idx, relates_to in enumerate(result.resource.relatesTo):
             if not (identifier := getattr(relates_to.target.identifier, "value", None)):
@@ -128,7 +131,7 @@ def handler(
                     diagnostics="The relatesTo target identifier value does not include the expected ODS code for this organisation",
                     expression=f"relatesTo[{idx}].target.identifier.value",
                 )
-            if PERMISSION_SUPERSEDE_IGNORE_DELETE_FAIL not in metadata.nrl_permissions:
+            if not can_ignore_delete_fail:
                 if not (existing_pointer := repository.get_by_id(identifier)):
                     logger.log(
                         LogReference.PROCREATE007c, related_identifier=identifier
@@ -171,7 +174,7 @@ def handler(
             ids_to_delete=ids_to_delete,
         )
         saved_model = repository.supersede(
-            core_model, ids_to_delete, metadata.nrl_permissions
+            core_model, ids_to_delete, can_ignore_delete_fail
         )
         logger.log(LogReference.PROUPSERT999)
         return NRLResponse.RESOURCE_SUPERSEDED(resource_id=saved_model.id)

layer/nrlf/core/dynamodb/repository.py

@@ -7,7 +7,6 @@
 
 from nrlf.core.boto import get_dynamodb_resource, get_dynamodb_table
 from nrlf.core.codes import SpineErrorConcept
-from nrlf.core.constants import PERMISSION_SUPERSEDE_IGNORE_DELETE_FAIL
 from nrlf.core.dynamodb.model import DocumentPointer, DynamoDBModel
 from nrlf.core.errors import OperationOutcomeError
 from nrlf.core.logger import LogReference, logger
@@ -378,13 +377,11 @@ def supersede(
         self,
         item: DocumentPointer,
         ids_to_delete: List[str],
-        nrl_permissions: list[str] = [],
+        can_ignore_delete_fail: list[str] = [],
     ) -> DocumentPointer:
         """ """
         saved_item = self.create(item)
-        can_ignore_delete_fail = (
-            PERMISSION_SUPERSEDE_IGNORE_DELETE_FAIL in nrl_permissions
-        )
+
         for id_ in ids_to_delete:
             self.delete_by_id(id_, can_ignore_delete_fail)
 
@@ -434,18 +431,6 @@ def delete_by_id(self, id_: str, can_ignore_delete_fail: bool = False):
                     error=str(exc),
                 )
                 return
-            logger.log(
-                LogReference.REPOSITORY026,
-                exc_info=sys.exc_info(),
-                stacklevel=5,
-                error=str(exc),
-            )
-            raise OperationOutcomeError(
-                status_code="500",
-                severity="error",
-                code="exception",
-                details=SpineErrorConcept.from_code("INTERNAL_SERVER_ERROR"),
-            ) from exc
 
     def _query(self, **kwargs) -> Iterator[DocumentPointer]:
         """