NRL-693 remove useless vars

Author: eesa456

terraform/account-wide-infrastructure/modules/lambda-errors-metric-alarm/cloudwatch.tf

@@ -1,55 +1,17 @@
 resource "aws_cloudwatch_metric_alarm" "metric_alarm" {
   alarm_name        = "${var.name_prefix}--lambda-errors-metric_alarm"
   alarm_description = var.alarm_description
-  actions_enabled   = var.actions_enabled
 
-  alarm_actions             = [aws_sns_topic.sns_topic.arn]
-  ok_actions                = var.ok_actions
-  insufficient_data_actions = var.insufficient_data_actions
+  alarm_actions = [aws_sns_topic.sns_topic.arn]
 
   comparison_operator = var.comparison_operator
   evaluation_periods  = var.evaluation_periods
   threshold           = var.threshold
   unit                = var.unit
 
-  datapoints_to_alarm                   = var.datapoints_to_alarm
-  treat_missing_data                    = var.treat_missing_data
-  evaluate_low_sample_count_percentiles = var.evaluate_low_sample_count_percentiles
+  metric_name = var.metric_name
+  namespace   = var.namespace
+  period      = var.period
+  statistic   = var.statistic
 
-  # conflicts with metric_query
-  metric_name        = var.metric_name
-  namespace          = var.namespace
-  period             = var.period
-  statistic          = var.statistic
-  extended_statistic = var.extended_statistic
-
-  dimensions = var.dimensions
-
-  # conflicts with metric_name
-  dynamic "metric_query" {
-    for_each = var.metric_query
-    content {
-      id          = lookup(metric_query.value, "id")
-      account_id  = lookup(metric_query.value, "account_id", null)
-      label       = lookup(metric_query.value, "label", null)
-      return_data = lookup(metric_query.value, "return_data", null)
-      expression  = lookup(metric_query.value, "expression", null)
-      period      = lookup(metric_query.value, "period", null)
-
-      dynamic "metric" {
-        for_each = lookup(metric_query.value, "metric", [])
-        content {
-          metric_name = lookup(metric.value, "metric_name")
-          namespace   = lookup(metric.value, "namespace")
-          period      = lookup(metric.value, "period")
-          stat        = lookup(metric.value, "stat")
-          unit        = lookup(metric.value, "unit", null)
-          dimensions  = lookup(metric.value, "dimensions", null)
-        }
-      }
-    }
-  }
-  threshold_metric_id = var.threshold_metric_id
-
-  tags = var.tags
 }

terraform/account-wide-infrastructure/modules/lambda-errors-metric-alarm/vars.tf

@@ -20,12 +20,6 @@ variable "threshold" {
   default     = null
 }
 
-variable "threshold_metric_id" {
-  description = "If this is an alarm based on an anomaly detection model, make this value match the ID of the ANOMALY_DETECTION_BAND function."
-  type        = string
-  default     = null
-}
-
 variable "unit" {
   description = "The unit for the alarm's associated metric."
   type        = string
@@ -56,72 +50,6 @@ variable "statistic" {
   default     = null
 }
 
-variable "actions_enabled" {
-  description = "Indicates whether or not actions should be executed during any changes to the alarm's state. Defaults to true."
-  type        = bool
-  default     = true
-}
-
-variable "datapoints_to_alarm" {
-  description = "The number of datapoints that must be breaching to trigger the alarm."
-  type        = number
-  default     = null
-}
-
-variable "dimensions" {
-  description = "The dimensions for the alarm's associated metric."
-  type        = any
-  default     = null
-}
-
-variable "alarm_actions" {
-  description = "The list of actions to execute when this alarm transitions into an ALARM state from any other state. Each action is specified as an Amazon Resource Name (ARN)."
-  type        = list(string)
-  default     = null
-}
-
-variable "insufficient_data_actions" {
-  description = "The list of actions to execute when this alarm transitions into an INSUFFICIENT_DATA state from any other state. Each action is specified as an Amazon Resource Name (ARN)."
-  type        = list(string)
-  default     = null
-}
-
-variable "ok_actions" {
-  description = "The list of actions to execute when this alarm transitions into an OK state from any other state. Each action is specified as an Amazon Resource Name (ARN)."
-  type        = list(string)
-  default     = null
-}
-
-variable "extended_statistic" {
-  description = "The percentile statistic for the metric associated with the alarm. Specify a value between p0.0 and p100."
-  type        = string
-  default     = null
-}
-
-variable "treat_missing_data" {
-  description = "Sets how this alarm is to handle missing data points. The following values are supported: missing, ignore, breaching and notBreaching."
-  type        = string
-  default     = "missing"
-}
-
-variable "evaluate_low_sample_count_percentiles" {
-  description = "Used only for alarms based on percentiles. If you specify ignore, the alarm state will not change during periods with too few data points to be statistically significant. If you specify evaluate or omit this parameter, the alarm will always be evaluated and possibly change state no matter how many data points are available. The following values are supported: ignore, and evaluate."
-  type        = string
-  default     = null
-}
-
-variable "metric_query" {
-  description = "Enables you to create an alarm based on a metric math expression. You may specify at most 20."
-  type        = any
-  default     = []
-}
-
-variable "tags" {
-  description = "A mapping of tags to assign to all resources"
-  type        = map(string)
-  default     = {}
-}
-
 variable "name_prefix" {
   type        = string
   description = "The prefix to apply to all resources in the module."