NRL-1554 Remove check for empty content extension as it is checked in pydantic, add relevant tests

Author: axelkrastek1-nhs

layer/nrlf/core/tests/test_pydantic_errors.py

@@ -439,3 +439,31 @@ def test_validate_missing_display_from_coding_where_mandatory():
         "diagnostics": "Failed to parse DocumentReference resource (context.practiceSetting.coding[0].display: Field required)",
         "expression": ["context.practiceSetting.coding[0].display"],
     }
+
+
+def test_validate_content_no_content_extension():
+    validator = DocumentReferenceValidator()
+    document_ref_data = load_document_reference_json("Y05868-736253002-Valid")
+
+    document_ref_data["content"][0].pop("extension")
+
+    with pytest.raises(ParseError) as error:
+        validator.validate(document_ref_data)
+
+    exc = error.value
+    assert len(exc.issues) == 1
+    assert exc.issues[0].model_dump(exclude_none=True) == {
+        "severity": "error",
+        "code": "invalid",
+        "details": {
+            "coding": [
+                {
+                    "system": "https://fhir.nhs.uk/CodeSystem/Spine-ErrorOrWarningCode",
+                    "code": "BAD_REQUEST",
+                    "display": "Bad request",
+                }
+            ]
+        },
+        "diagnostics": "Failed to parse DocumentReference resource (content[0].extension: Field required)",
+        "expression": ["content[0].extension"],
+    }

layer/nrlf/core/validators.py

@@ -514,15 +514,6 @@ def _validate_content_extension(self, model: DocumentReference):
         logger.debug("Validating extension")
 
         for i, content in enumerate(model.content):
-            if not content.extension:
-                self.result.add_error(
-                    issue_code="business-rule",
-                    error_code="UNPROCESSABLE_ENTITY",
-                    diagnostics="Invalid content extension: Extension must have at least one value",
-                    field=f"content[{i}].extension",
-                )
-                return
-
             if not self._has_valid_extensions(content.extension, i):
                 return
 

tests/features/producer/createDocumentReference-failure.feature

@@ -1044,3 +1044,48 @@ Feature: Producer - createDocumentReference - Failure Scenarios
         "expression": ["DocumentReference"]
       }
       """
+
+  Scenario: RetrievalMechanism extension is empty
+    Given the application 'DataShare' (ID 'z00z-y11y-x22x') is registered to access the API
+    And the organisation 'TSTCUS' is authorised to access pointer types:
+      | system                 | value     |
+      | http://snomed.info/sct | 736253002 |
+    When producer 'TSTCUS' requests creation of a DocumentReference with default test values except 'content' is:
+      """
+      "content": [
+        {
+          "attachment": {
+            "contentType": "application/pdf",
+            "url": "https://example.org/my-doc.pdf"
+          },
+          "format": {
+            "system": "https://fhir.nhs.uk/England/CodeSystem/England-NRLFormatCode",
+            "code": "urn:nhs-ic:unstructured",
+            "display": "Unstructured Document"
+          },
+          "extension": []
+        }
+      ]
+      """
+    Then the response status code is 400
+    And the response is an OperationOutcome with 1 issue
+    And the OperationOutcome contains the issue:
+      """
+      {
+        "severity": "error",
+        "code": "invalid",
+        "details": {
+          "coding": [
+            {
+              "system": "https://fhir.nhs.uk/CodeSystem/Spine-ErrorOrWarningCode",
+              "code": "MESSAGE_NOT_WELL_FORMED",
+              "display": "Message not well formed"
+            }
+          ]
+        },
+        "diagnostics": "Request body could not be parsed (DocumentReference: Value error, The following fields are empty: content[0].extension)",
+        "expression": [
+          "DocumentReference"
+        ]
+      }
+      """