NRL-708 initial exception handling

Author: eesa456

api/producer/createDocumentReference/create_document_reference.py

@@ -1,5 +1,7 @@
 from uuid import uuid4
 
+from core.errors import OperationOutcomeError
+
 from nrlf.core.constants import PERMISSION_AUDIT_DATES_FROM_PAYLOAD
 from nrlf.core.decorators import request_handler
 from nrlf.core.dynamodb.repository import DocumentPointer, DocumentPointerRepository
@@ -74,10 +76,20 @@ def handler(
         document_reference=result.resource,
         nrl_permissions=metadata.nrl_permissions,
     )
-
-    core_model = DocumentPointer.from_document_reference(
-        document_reference, created_on=creation_time
-    )
+    try:
+        core_model = DocumentPointer.from_document_reference(
+            document_reference, created_on=creation_time
+        )
+    except OperationOutcomeError as exc:
+        return SpineErrorResponse.BAD_REQUEST(
+            diagnostics=exc.diagnostics,
+            expression="DocumentReference.type.coding",
+        )
+    except Exception as exc:
+        return SpineErrorResponse.BAD_REQUEST(
+            diagnostics=f"Parsing of Document Pointer has raised exception with message: '{str(exc)}'.",
+            expression="DocumentReference",
+        )
 
     custodian_parts = tuple(
         filter(None, (core_model.custodian, core_model.custodian_suffix))

layer/nrlf/core/dynamodb/model.py

@@ -3,6 +3,8 @@
 from enum import Enum
 from typing import Any, Dict, Optional
 
+from core.codes import SpineErrorConcept
+from core.errors import OperationOutcomeError
 from nhs_number import is_valid as is_valid_nhs_number
 from pydantic import BaseModel, Field, PrivateAttr, root_validator, validator
 
@@ -77,7 +79,13 @@ def from_document_reference(
         custodian = getattr(custodian_identifier, "value")
 
         if len(coding) > 1:
-            raise ValueError("DocumentReference.type.coding must have exactly one item")
+            raise OperationOutcomeError(
+                status_code="400",
+                severity="error",
+                code="invalid",
+                details=SpineErrorConcept.from_code("INVALID_RESOURCE"),
+                diagnostics="DocumentReference.type.coding must have exactly one item",
+            ) from None
 
         pointer_type = f"{coding[0].system}|{coding[0].code}"