Skip to content

Commit 26fd357

Browse files
NRL-1798 Update unit test assertions
1 parent 16b2f39 commit 26fd357

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

scripts/delete_pointers_by_id.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,10 @@ def _delete_pointers_by_id(
282282
pointers_to_delete: List of pointer IDs as JSON string
283283
pointers_file: Path to file containing pointer IDs
284284
"""
285-
if not pointers_to_delete and not pointers_file:
285+
if pointers_to_delete is None and pointers_file is None:
286286
raise ValueError("Must provide either --pointers_to_delete or --pointers_file")
287287

288-
if pointers_to_delete and pointers_file:
288+
if pointers_to_delete is not None and pointers_file is not None:
289289
raise ValueError("Cannot provide both --pointers_to_delete and --pointers_file")
290290

291291
if pointers_file:

scripts/tests/test_delete_pointers_by_id.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,14 +233,15 @@ def test_some_unprocessed(self, mock_dynamodb):
233233
class TestDeletePointersById:
234234
def test_missing_params(self):
235235
with pytest.raises(
236-
ValueError, match="Provide either pointers_to_delete or pointers_file"
236+
ValueError,
237+
match="Must provide either --pointers_to_delete or --pointers_file",
237238
):
238239
_delete_pointers_by_id("t", "G3H9E")
239240

240241
def test_both_params_provided(self):
241242
with pytest.raises(
242243
ValueError,
243-
match="Provide either pointers_to_delete or pointers_file, not both",
244+
match="Cannot provide both --pointers_to_delete and --pointers_file",
244245
):
245246
_delete_pointers_by_id(
246247
"t", "G3H9E", pointers_to_delete=["a"], pointers_file="./f"

0 commit comments

Comments
 (0)