Merge pull request #719 from NHSDigital/features/made14-NRL-987-fix-mgmt-infra

[NRL-987] Remove unused RDS cluster networking from mgmt account

Author: mattdean3-nhs

terraform/account-wide-infrastructure/README.md

@@ -20,6 +20,29 @@ Before deploying the NRLF account-wide infrastructure, you will need:
 - AWS accounts that have already been bootstrapped, as described in [bootstrap/README.md](../bootstrap/README.md). This is a one-time account setup step.
 - The required packages to build NRLF, see [the Setup section in README.md](../../README.md#setup).
 
+## Deploy mgmt resources
+
+To deploy resources into the mgmt account, first login to the AWS mgmt account on the CLI.
+
+Then, initialise your terraform workspace with:
+
+```shell
+cd mgmt
+terraform init && terraform workspace select mgmt
+```
+
+Once you have your workspace, you can plan your change with:
+
+```shell
+terraform plan
+```
+
+Once you're happy with your planned changes, you can apply them with:
+
+```shell
+terraform apply
+```
+
 ## Deploy account wide resources
 
 To deploy the account wide resources, first login to the AWS mgmt account on the CLI.

terraform/account-wide-infrastructure/mgmt/rds-cluster-vpc.tf

@@ -124,16 +124,7 @@ resource "aws_route53_record" "NEW_dev_zone_delegation" {
   type = "NS"
 }
 
-// TODO-NOW - Get these QA zone changes reflected in mgmt account (w/ Tom or Kate)
-resource "aws_route53_zone" "qa_zone" {
-  name = "qa.record-locator.national.nhs.uk"
-
-  tags = {
-    Environment = terraform.workspace
-  }
-}
-
-resource "aws_route53_record" "qa_zone_delegation" {
+resource "aws_route53_record" "NEW_qa_zone_delegation" {
   zone_id = aws_route53_zone.prod_zone.zone_id
   name    = "qa.record-locator.national.nhs.uk"
   records = [