NRL-1188 Reference existing bucket

Author: jackleary

terraform/infrastructure/firehose.tf

@@ -8,5 +8,4 @@ module "firehose__processor" {
   splunk_environment = local.splunk_environment
   splunk_index       = local.splunk_index
   destination        = "splunk"
-  reporting_bucket   = module.dev-glue.source_bucket_name
 }

terraform/infrastructure/modules/firehose/kinesis.tf

@@ -63,7 +63,7 @@ resource "aws_kinesis_firehose_delivery_stream" "reporting_stream" {
 
   extended_s3_configuration {
     role_arn   = aws_iam_role.firehose.arn
-    bucket_arn = var.reporting_bucket
+    bucket_arn = data.aws_s3_bucket.source-data-bucket.arn
 
     processing_configuration {
       enabled = "true"

terraform/infrastructure/modules/firehose/s3.tf

@@ -106,3 +106,7 @@ resource "aws_iam_policy" "firehose-alert--s3-read" {
     ]
   })
 }
+
+data "aws_s3_bucket" "source-data-bucket" {
+  bucket = "${var.prefix}-source-data-bucket"
+}

terraform/infrastructure/modules/firehose/vars.tf

@@ -34,7 +34,3 @@ variable "error_prefix" {
   type    = string
   default = "errors"
 }
-
-variable "reporting_bucket" {
-  type = string
-}