NRL-505 All business validation errors are now 422 Unprocessable Entity

Author: axelkrastek1-nhs

api/consumer/countDocumentReference/count_document_reference.py

@@ -29,7 +29,7 @@ def handler(
         logger.log(
             LogReference.CONCOUNT001, subject_identifier=params.subject_identifier
         )
-        return SpineErrorResponse.INVALID_IDENTIFIER_VALUE(
+        return SpineErrorResponse.UNPROCESSABLE_ENTITY(
             diagnostics="Invalid NHS number provided in the query parameters",
             expression="subject:identifier",
         )

api/consumer/countDocumentReference/tests/test_count_document_reference.py

@@ -100,7 +100,7 @@ def test_count_document_reference_invalid_nhs_number():
     body = result.pop("body")
 
     assert result == {
-        "statusCode": "400",
+        "statusCode": "422",
         "headers": default_response_headers(),
         "isBase64Encoded": False,
     }
@@ -111,13 +111,13 @@ def test_count_document_reference_invalid_nhs_number():
         "issue": [
             {
                 "severity": "error",
-                "code": "invalid",
+                "code": "business-rule",
                 "details": {
                     "coding": [
                         {
                             "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
-                            "code": "INVALID_IDENTIFIER_VALUE",
-                            "display": "Invalid identifier value",
+                            "code": "UNPROCESSABLE_ENTITY",
+                            "display": "Unprocessable Entity",
                         }
                     ]
                 },

api/producer/createDocumentReference/create_document_reference.py

@@ -73,7 +73,7 @@ def _check_permissions(
             ods_code_parts=metadata.ods_code_parts,
             custodian_parts=custodian_parts,
         )
-        return SpineErrorResponse.BAD_REQUEST(
+        return SpineErrorResponse.UNPROCESSABLE_ENTITY(
             diagnostics="The custodian of the provided DocumentReference does not match the expected ODS code for this organisation",
             expression="custodian.identifier.value",
         )
@@ -201,10 +201,11 @@ def _raise_operation_outcome_error(diagnostics, idx):
     """
     raise OperationOutcomeError(
         severity="error",
-        code="invalid",
-        details=SpineErrorConcept.from_code("BAD_REQUEST"),
+        code="business-rule",
+        details=SpineErrorConcept.from_code("UNPROCESSABLE_ENTITY"),
         diagnostics=diagnostics,
         expression=[f"relatesTo[{idx}].target.identifier.value"],
+        status_code="422",
     )
 
 
@@ -236,7 +237,7 @@ def handler(
 
     if not result.is_valid:
         logger.log(LogReference.PROCREATE002)
-        return Response.from_issues(issues=result.issues, statusCode="400")
+        return Response.from_issues(issues=result.issues, statusCode="422")
 
     core_model = _create_core_model(result.resource, metadata)
     if error_response := _check_permissions(core_model, metadata):