NRL-738 add new perm check

Author: eesa456

layer/nrlf/core/constants.py

@@ -31,6 +31,8 @@ class Source(Enum):
 CONNECTION_METADATA = "nhsd-connection-metadata"
 PERMISSION_AUDIT_DATES_FROM_PAYLOAD = "audit-dates-from-payload"
 PERMISSION_SUPERSEDE_IGNORE_DELETE_FAIL = "supersede-ignore-delete-fail"
+PERMISSION_ALLOW_ALL_POINTER_TYPES = "allow-all-pointer-types"
+
 
 PRODUCER_URL_PATH = "/nrl-producer-api/FHIR/R4/DocumentReference"
 POINTER_TYPES = {

layer/nrlf/core/decorators.py

@@ -15,7 +15,7 @@
 from nrlf.core.authoriser import get_pointer_types
 from nrlf.core.codes import SpineErrorConcept
 from nrlf.core.config import Config
-from nrlf.core.constants import POINTER_TYPES
+from nrlf.core.constants import PERMISSION_ALLOW_ALL_POINTER_TYPES, POINTER_TYPES
 from nrlf.core.dynamodb.repository import DocumentPointerRepository
 from nrlf.core.errors import OperationOutcomeError, ParseError
 from nrlf.core.logger import LogReference, logger
@@ -67,7 +67,7 @@ def load_connection_metadata(headers: Dict[str, str], config: Config):
     logger.log(LogReference.HANDLER002, headers=headers)
     metadata = parse_headers(headers)
     logger.log(LogReference.HANDLER003, metadata=metadata.dict())
-    if metadata.nrl_permissions:
+    if PERMISSION_ALLOW_ALL_POINTER_TYPES in metadata.nrl_permissions:
         logger.log(LogReference.HANDLER004a)
         metadata.pointer_types = [
             f"http://snomed.info/sct|{key}" for key in list(POINTER_TYPES.keys())

layer/nrlf/core/dynamodb/repository.py

@@ -430,7 +430,6 @@ def delete_by_id(self, id_: str, can_ignore_delete_fail: bool = False):
                     stacklevel=5,
                     error=str(exc),
                 )
-                return
 
     def _query(self, **kwargs) -> Iterator[DocumentPointer]:
         """