NRL-693 change from _ to -

Author: eesa456

terraform/account-wide-infrastructure/modules/lambda-errors-metric-alarm/cloudwatch.tf

@@ -1,5 +1,5 @@
 resource "aws_cloudwatch_metric_alarm" "metric_alarm" {
-  alarm_name        = "${var.name_prefix}--lambda-errors-metric_alarm"
+  alarm_name        = "${var.name_prefix}--lambda-errors-metric-alarm"
   alarm_description = var.alarm_description
 
   alarm_actions = [aws_sns_topic.sns_topic.arn]