NRL-1188 Resolving comments

Author: jackleary

terraform/account-wide-infrastructure/modules/glue/iam.tf

@@ -21,18 +21,6 @@ resource "aws_iam_role_policy" "glue_service_role_policy" {
   policy = jsonencode({
     "Version" : "2012-10-17",
     "Statement" : [
-      # {
-      #   "Effect" : "Allow",
-      #   "Action" : [
-      #     "glue:*",
-      #     "s3:GetBucketLocation",
-      #     "s3:ListBucket",
-      #     "s3:ListAllMyBuckets",
-      #     "s3:GetBucketAcl",
-      #     "cloudwatch:PutMetricData"
-      #   ],
-      #   "Resource" : ["*"]
-      # },
       {
         "Effect" : "Allow",
         "Action" : ["s3:CreateBucket"],

terraform/account-wide-infrastructure/modules/glue/s3.tf

@@ -125,7 +125,7 @@ resource "aws_s3_bucket_public_access_block" "code-bucket-public-access-block" {
   restrict_public_buckets = true
 }
 
-resource "aws_s3_bucket_object" "code-data-object" {
+resource "aws_s3_bucket_object" "script" {
   bucket = aws_s3_bucket.code-bucket.bucket
   key    = "main.py"
   source = "${path.module}/src/main.py"
@@ -139,7 +139,7 @@ data "archive_file" "python" {
   source_dir = "${path.module}/src"
 }
 
-resource "aws_s3_bucket_object" "code-data-object" {
+resource "aws_s3_bucket_object" "zip" {
   bucket = aws_s3_bucket.code-bucket.bucket
   key    = "main.py"
   source = data.archive_file.python

terraform/account-wide-infrastructure/modules/truststore-bucket/output.tf

@@ -1,9 +1,9 @@
 output "bucket_name" {
-  description = "Name of the reporting S3 bucket"
+  description = "Name of the truststore S3 bucket"
   value       = aws_s3_bucket.api_truststore.bucket
 }
 
 output "certificates_object_key" {
-  description = "Key of the reporting certificates object"
+  description = "Key of the truststore certificates object"
   value       = aws_s3_object.api_truststore_certificate.key
 }