NRL-1050 Add tests and fix tests for type validation

Author: axelkrastek1-nhs

api/producer/createDocumentReference/tests/test_create_document_reference.py

@@ -1,4 +1,5 @@
 import json
+from unittest.mock import patch
 
 from freeze_uuid import freeze_uuid
 from freezegun import freeze_time
@@ -412,6 +413,70 @@ def test_create_document_reference_invalid_pointer_type():
     result = handler(event, create_mock_context())
     body = result.pop("body")
 
+    assert result == {
+        "statusCode": "400",
+        "headers": default_response_headers(),
+        "isBase64Encoded": False,
+    }
+
+    parsed_body = json.loads(body)
+
+    assert parsed_body == {
+        "resourceType": "OperationOutcome",
+        "issue": [
+            {
+                "severity": "error",
+                "code": "value",
+                "details": {
+                    "coding": [
+                        {
+                            "code": "INVALID_RESOURCE",
+                            "display": "Invalid validation of resource",
+                            "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+                        }
+                    ]
+                },
+                "diagnostics": "Invalid type code: invalid Type must be a member of the England-NRLRecordType value set (https://fhir.nhs.uk/England/CodeSystem/England-NRLRecordType)",
+                "expression": ["type.coding[0].code"],
+            },
+            {
+                "severity": "error",
+                "code": "value",
+                "details": {
+                    "coding": [
+                        {
+                            "code": "INVALID_RESOURCE",
+                            "display": "Invalid validation of resource",
+                            "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+                        }
+                    ]
+                },
+                "diagnostics": "type (http://snomed.info/sct|invalid) does not map to the category: http://snomed.info/sct|734163000",
+                "expression": ["type.coding[0]"],
+            },
+        ],
+    }
+
+
+@mock_aws
+@mock_repository
+@patch("nrlf.core.decorators.parse_permissions_file")
+def test_create_document_reference_pointer_type_not_allowed(
+    parse_permissions_mock, repository: DocumentPointerRepository
+):
+    doc_ref = load_document_reference("Y05868-736253002-Valid")
+
+    assert doc_ref.type and doc_ref.type.coding
+
+    event = create_test_api_gateway_event(
+        headers=create_headers(),
+        body=doc_ref.model_dump_json(exclude_none=True),
+    )
+
+    parse_permissions_mock.return_value = ["invalid"]
+    result = handler(event, create_mock_context())
+    body = result.pop("body")
+
     assert result == {
         "statusCode": "403",
         "headers": default_response_headers(),
@@ -757,6 +822,7 @@ def test_create_document_reference_invalid_relatesto_type(
 
     assert doc_ref.type and doc_ref.type.coding
     doc_ref.type.coding[0].code = "861421000000109"
+    doc_ref.type.coding[0].display = "End of Life Care Coordination Summary"
     doc_ref.relatesTo = [
         DocumentReferenceRelatesTo(
             code="transforms",

api/producer/updateDocumentReference/tests/test_update_document_reference.py

@@ -500,8 +500,8 @@ def test_update_document_reference_immutable_fields(repository):
                 id=None,
                 system="http://snomed.info/sct",
                 version=None,
-                code="1213324",
-                display="Some Code",
+                code="861421000000109",
+                display="End of Life Care Coordination Summary",
                 userSelected=None,
             )
         ],

api/producer/upsertDocumentReference/tests/test_upsert_document_reference.py

@@ -1,4 +1,5 @@
 import json
+from unittest.mock import patch
 
 from freezegun import freeze_time
 from moto import mock_aws
@@ -538,6 +539,70 @@ def test_upsert_document_reference_invalid_pointer_type():
     result = handler(event, create_mock_context())
     body = result.pop("body")
 
+    assert result == {
+        "statusCode": "400",
+        "headers": default_response_headers(),
+        "isBase64Encoded": False,
+    }
+
+    parsed_body = json.loads(body)
+
+    assert parsed_body == {
+        "resourceType": "OperationOutcome",
+        "issue": [
+            {
+                "severity": "error",
+                "code": "value",
+                "details": {
+                    "coding": [
+                        {
+                            "code": "INVALID_RESOURCE",
+                            "display": "Invalid validation of resource",
+                            "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+                        }
+                    ]
+                },
+                "diagnostics": "Invalid type code: invalid Type must be a member of the England-NRLRecordType value set (https://fhir.nhs.uk/England/CodeSystem/England-NRLRecordType)",
+                "expression": ["type.coding[0].code"],
+            },
+            {
+                "severity": "error",
+                "code": "value",
+                "details": {
+                    "coding": [
+                        {
+                            "code": "INVALID_RESOURCE",
+                            "display": "Invalid validation of resource",
+                            "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+                        }
+                    ]
+                },
+                "diagnostics": "type (http://snomed.info/sct|invalid) does not map to the category: http://snomed.info/sct|734163000",
+                "expression": ["type.coding[0]"],
+            },
+        ],
+    }
+
+
+@mock_aws
+@mock_repository
+@patch("nrlf.core.decorators.parse_permissions_file")
+def test_upsert_document_reference_pointer_type_not_allowed(
+    parse_permissions_mock, repository: DocumentPointerRepository
+):
+    doc_ref = load_document_reference("Y05868-736253002-Valid")
+
+    assert doc_ref.type and doc_ref.type.coding
+
+    event = create_test_api_gateway_event(
+        headers=create_headers(),
+        body=doc_ref.model_dump_json(exclude_none=True),
+    )
+
+    parse_permissions_mock.return_value = ["invalid"]
+    result = handler(event, create_mock_context())
+    body = result.pop("body")
+
     assert result == {
         "statusCode": "403",
         "headers": default_response_headers(),
@@ -848,6 +913,7 @@ def test_upsert_document_reference_invalid_relatesto_type(
 
     assert doc_ref.type and doc_ref.type.coding
     doc_ref.type.coding[0].code = "861421000000109"
+    doc_ref.type.coding[0].display = "End of Life Care Coordination Summary"
     doc_ref.relatesTo = [
         DocumentReferenceRelatesTo(
             code="transforms",