NRL-746 add display check

Author: eesa456

layer/nrlf/core/tests/test_validators.py

@@ -679,6 +679,47 @@ def test_validate_content_extension_invalid_code():
     }
 
 
+def test_validate_content_extension_invalid_display():
+    validator = DocumentReferenceValidator()
+    document_ref_data = load_document_reference_json("Y05868-736253002-Valid")
+
+    document_ref_data["content"][0]["extension"][0] = {
+        "url": "https://fhir.nhs.uk/England/StructureDefinition/Extension-England-ContentStability",
+        "valueCodeableConcept": {
+            "coding": [
+                {
+                    "system": "https://fhir.nhs.uk/England/CodeSystem/England-NRLContentStability",
+                    "code": "static",
+                    "display": "invalid",
+                }
+            ]
+        },
+    }
+
+    result = validator.validate(document_ref_data)
+
+    assert result.is_valid is False
+    assert result.resource.id == "Y05868-99999-99999-999999"
+    assert len(result.issues) == 1
+    assert result.issues[0].dict(exclude_none=True) == {
+        "severity": "error",
+        "code": "value",
+        "details": {
+            "coding": [
+                {
+                    "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+                    "code": "INVALID_RESOURCE",
+                    "display": "Invalid validation of resource",
+                }
+            ]
+        },
+        "diagnostics": "Invalid content extension display: invalid Extension display must be the same as code either 'static' or 'dynamic'",
+        "expression": [
+            "content[0].extension[0].valueCodeableConcept.coding[0].display"
+        ],
+    }
+
+
 def test_validate_content_extension_invalid_system():
     validator = DocumentReferenceValidator()
     document_ref_data = load_document_reference_json("Y05868-736253002-Valid")

layer/nrlf/core/validators.py

@@ -461,6 +461,23 @@ def _validate_content_extension(self, model: DocumentReference):
                 )
                 return
 
+            if (
+                content.extension[0].valueCodeableConcept.coding[0].code
+                != content.extension[0].valueCodeableConcept.coding[0].display.lower()
+            ):
+                logger.log(
+                    LogReference.VALIDATOR001,
+                    step=f"content[{i}].extension.valueCodeableConcept.coding[0].display",
+                    reason="extension_coding_display_invalid",
+                )
+                self.result.add_error(
+                    issue_code="value",
+                    error_code="INVALID_RESOURCE",
+                    diagnostics=f"Invalid content extension display: {content.extension[0].valueCodeableConcept.coding[0].display} Extension display must be the same as code either 'static' or 'dynamic'",
+                    field=f"content[{i}].extension[0].valueCodeableConcept.coding[0].display",
+                )
+                return
+
             if (
                 content.extension[0].url
                 != "https://fhir.nhs.uk/England/StructureDefinition/Extension-England-ContentStability"