NRL-1320 sonar changes

jackleary · jackleary · commit ab32be96be9a · 2025-02-28T17:13:43.000Z
diff --git a/terraform/account-wide-infrastructure/modules/glue/src/transformations.py b/terraform/account-wide-infrastructure/modules/glue/src/transformations.py
@@ -38,7 +38,8 @@ def flatten_df(df):
         [
             (field.name, field.dataType)
             for field in df.schema.fields
-            if type(field.dataType) == ArrayType or type(field.dataType) == StructType
+            if isinstance(field.dataType, ArrayType)
+            or isinstance(field.dataType, StructType)
         ]
     )
     while len(complex_fields) != 0:

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,8 @@ def flatten_df(df):`
`38`	`38`	`[`
`39`	`39`	`(field.name, field.dataType)`
`40`	`40`	`for field in df.schema.fields`
`41`		`- if type(field.dataType) == ArrayType or type(field.dataType) == StructType`
	`41`	`+ if isinstance(field.dataType, ArrayType)`
	`42`	`+ or isinstance(field.dataType, StructType)`
`42`	`43`	`]`
`43`	`44`	`)`
`44`	`45`	`while len(complex_fields) != 0:`