NRL-1187 remove unused resources

jackleary · jackleary · commit ab4e6b3e4434 · 2025-01-13T10:33:02.000Z
diff --git a/terraform/account-wide-infrastructure/modules/athena/athena.tf b/terraform/account-wide-infrastructure/modules/athena/athena.tf
@@ -1,16 +1,3 @@
-# resource "aws_athena_database" "reporting-db" {
-#   name = var.database
-
-#   bucket = var.target_bucket_name
-
-#   encryption_configuration {
-#     encryption_option = "SSE_KMS"
-#     kms_key           = aws_kms_key.athena.arn
-#   }
-
-#   force_destroy = true
-# }
-
 resource "aws_athena_workgroup" "athena" {
   name = "${var.name_prefix}-athena-wg"
 
diff --git a/terraform/account-wide-infrastructure/modules/athena/outputs.tf b/terraform/account-wide-infrastructure/modules/athena/outputs.tf
@@ -5,7 +5,3 @@ output "workgroup" {
 output "bucket" {
   value = aws_s3_bucket.athena
 }
-
-# output "database" {
-#   value = aws_athena_database.reporting-db
-# }
diff --git a/terraform/account-wide-infrastructure/modules/glue/iam.tf b/terraform/account-wide-infrastructure/modules/glue/iam.tf
@@ -91,8 +91,3 @@ resource "aws_iam_role_policy_attachment" "glue_service" {
   role       = aws_iam_role.glue_service_role.name
   policy_arn = aws_iam_policy.glue_service.arn
 }
-
-# resource "aws_iam_role_policy_attachment" "glue_service" {
-#   role       = aws_iam_role.glue_service_role.id
-#   policy_arn = "arn:aws:iam::aws:policy/service-role/AWSGlueServiceRole"
-# }

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,3 @@ output "workgroup" {`
`5`	`5`	`output "bucket" {`
`6`	`6`	`value = aws_s3_bucket.athena`
`7`	`7`	`}`
`8`		`-`
`9`		`-# output "database" {`
`10`		`-# value = aws_athena_database.reporting-db`
`11`		`-# }`
Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,3 @@ resource "aws_iam_role_policy_attachment" "glue_service" {`
`91`	`91`	`role = aws_iam_role.glue_service_role.name`
`92`	`92`	`policy_arn = aws_iam_policy.glue_service.arn`
`93`	`93`	`}`
`94`		`-`
`95`		`-# resource "aws_iam_role_policy_attachment" "glue_service" {`
`96`		`-# role = aws_iam_role.glue_service_role.id`
`97`		`-# policy_arn = "arn:aws:iam::aws:policy/service-role/AWSGlueServiceRole"`
`98`		`-# }`