[NRL-1386] Fix glue source bucket lifecycle auto-deletes

mattdean3-nhs · mattdean3-nhs · commit b25f5690f2a2 · 2025-06-16T18:51:04.000+01:00
diff --git a/terraform/account-wide-infrastructure/modules/glue/s3.tf b/terraform/account-wide-infrastructure/modules/glue/s3.tf
@@ -56,12 +56,16 @@ resource "aws_s3_bucket_lifecycle_configuration" "source-data-bucket-lifecycle"
 
 
   rule {
-    id     = "bucket-versioning-rule"
+    id     = "object-auto-delete-rule"
     status = "Enabled"
 
     expiration {
       days = local.s3.expiration.days
     }
+
+    noncurrent_version_expiration {
+      noncurrent_days = local.s3.expiration.days
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -56,12 +56,16 @@ resource "aws_s3_bucket_lifecycle_configuration" "source-data-bucket-lifecycle"`
`56`	`56`
`57`	`57`
`58`	`58`	`rule {`
`59`		`- id = "bucket-versioning-rule"`
	`59`	`+ id = "object-auto-delete-rule"`
`60`	`60`	`status = "Enabled"`
`61`	`61`
`62`	`62`	`expiration {`
`63`	`63`	`days = local.s3.expiration.days`
`64`	`64`	`}`
	`65`	`+`
	`66`	`+ noncurrent_version_expiration {`
	`67`	`+ noncurrent_days = local.s3.expiration.days`
	`68`	`+ }`
`65`	`69`	`}`
`66`	`70`	`}`
`67`	`71`