NRL-853 fix tags for table and buckets

katebobyn-nhs · katebobyn-nhs · commit bd0ce6b0a061 · 2024-11-22T14:44:20.000Z
diff --git a/terraform/account-wide-infrastructure/modules/permissions-store-bucket/s3.tf b/terraform/account-wide-infrastructure/modules/permissions-store-bucket/s3.tf
@@ -2,7 +2,11 @@ resource "aws_s3_bucket" "authorization-store" {
   bucket        = "${var.name_prefix}-authorization-store"
   force_destroy = var.enable_bucket_force_destroy
 
-  tags = {
+  tags = var.enable_backups ? {
+    Name               = "authorization store"
+    Environment        = "${var.name_prefix}"
+    NHSE-Enable-Backup = "daily"
+    } : {
     Name        = "authorization store"
     Environment = "${var.name_prefix}"
   }
diff --git a/terraform/account-wide-infrastructure/modules/pointers-table/dynamodb.tf b/terraform/account-wide-infrastructure/modules/pointers-table/dynamodb.tf
@@ -52,5 +52,5 @@ resource "aws_dynamodb_table" "pointers" {
     enabled = var.enable_pitr
   }
 
-  tags = var.enable_backups ? { NHSE-Enable-Backup : daily } : {}
+  tags = var.enable_backups ? { NHSE-Enable-Backup = "daily" } : {}
 }
diff --git a/terraform/account-wide-infrastructure/modules/truststore-bucket/s3.tf b/terraform/account-wide-infrastructure/modules/truststore-bucket/s3.tf
@@ -1,6 +1,7 @@
 resource "aws_s3_bucket" "api_truststore" {
   bucket        = "${var.name_prefix}-api-truststore"
   force_destroy = var.enable_bucket_force_destroy
+  tags          = var.enable_backups ? { NHSE-Enable-Backup = "daily" } : {}
 }
 
 resource "aws_s3_bucket_policy" "api_truststore_bucket_policy" {

Original file line number	Diff line number	Diff line change
`@@ -52,5 +52,5 @@ resource "aws_dynamodb_table" "pointers" {`
`52`	`52`	`enabled = var.enable_pitr`
`53`	`53`	`}`
`54`	`54`
`55`		`- tags = var.enable_backups ? { NHSE-Enable-Backup : daily } : {}`
	`55`	`+ tags = var.enable_backups ? { NHSE-Enable-Backup = "daily" } : {}`
`56`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`resource "aws_s3_bucket" "api_truststore" {`
`2`	`2`	`bucket = "${var.name_prefix}-api-truststore"`
`3`	`3`	`force_destroy = var.enable_bucket_force_destroy`
	`4`	`+ tags = var.enable_backups ? { NHSE-Enable-Backup = "daily" } : {}`
`4`	`5`	`}`
`5`	`6`
`6`	`7`	`resource "aws_s3_bucket_policy" "api_truststore_bucket_policy" {`