NRL-519 implement sonarcloud suggestions

katebobyn-nhs · katebobyn-nhs · commit bfc1850a3c60 · 2024-12-05T13:17:34.000Z
diff --git a/layer/nrlf/core/validators.py b/layer/nrlf/core/validators.py
@@ -640,7 +640,7 @@ def _validate_practiceSetting(self, model: DocumentReference):
                 issue_code="value",
                 error_code="INVALID_RESOURCE",
                 diagnostics=f"Invalid practice setting system: {practice_setting_system} Practice Setting system must be '{SNOMED_SYSTEM_URL}'",
-                field=f"context.practiceSetting.coding[0].system",
+                field="context.practiceSetting.coding[0].system",
             )
             return
 

Original file line number	Diff line number	Diff line change
`@@ -640,7 +640,7 @@ def _validate_practiceSetting(self, model: DocumentReference):`
`640`	`640`	`issue_code="value",`
`641`	`641`	`error_code="INVALID_RESOURCE",`
`642`	`642`	`diagnostics=f"Invalid practice setting system: {practice_setting_system} Practice Setting system must be '{SNOMED_SYSTEM_URL}'",`
`643`		`- field=f"context.practiceSetting.coding[0].system",`
	`643`	`+ field="context.practiceSetting.coding[0].system",`
`644`	`644`	`)`
`645`	`645`	`return`
`646`	`646`