NRL-1188 Pass s3 bucket arn as var

jackleary · jackleary · commit c83ec52dccc6 · 2024-12-17T09:04:26.000Z
diff --git a/terraform/infrastructure/data.tf b/terraform/infrastructure/data.tf
@@ -43,6 +43,5 @@ data "external" "current-info" {
 }
 
 data "aws_s3_bucket" "source-data-bucket" {
-  count  = var.use_shared_resources ? 1 : 0
   bucket = "${local.shared_prefix}-source-data-bucket"
 }
diff --git a/terraform/infrastructure/modules/firehose/kinesis.tf b/terraform/infrastructure/modules/firehose/kinesis.tf
@@ -63,7 +63,7 @@ resource "aws_kinesis_firehose_delivery_stream" "reporting_stream" {
 
   extended_s3_configuration {
     role_arn   = aws_iam_role.firehose.arn
-    bucket_arn = var.reporting_bucket[count.index].arn
+    bucket_arn = var.reporting_bucket.arn
 
     processing_configuration {
       enabled = "true"

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,5 @@ data "external" "current-info" {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`data "aws_s3_bucket" "source-data-bucket" {`
`46`		`- count = var.use_shared_resources ? 1 : 0`
`47`	`46`	`bucket = "${local.shared_prefix}-source-data-bucket"`
`48`	`47`	`}`