Merge pull request #698 from NHSDigital/feature/eema1-NRL-936-custodianTypeMatchIntegrationTests

NRL-936 add integration tests

Author: eesa456

api/producer/readDocumentReference/read_document_reference.py

@@ -59,7 +59,7 @@ def handler(
         document_reference = DocumentReference.parse_raw(result.document)
     except ValidationError as exc:
         logger.log(
-            LogReference.CONREAD003,
+            LogReference.PROREAD003,
             exc_info=sys.exc_info(),
             stacklevel=5,
             error=str(exc),

layer/nrlf/core/log_references.py

@@ -203,7 +203,7 @@ class LogReference(Enum):
         "EXCEPTION", "The DocumentReference resource could not be parsed"
     )
     CONPOSTSEARCH999 = _Reference(
-        "INFO", "Successfully completed consumer searchDocumentReference"
+        "INFO", "Successfully completed consumer searchPostDocumentReference"
     )
 
     # Producer - CreateDocumentReference

tests/features/producer/createDocumentReference-failure.feature

@@ -257,6 +257,44 @@ Feature: Producer - createDocumentReference - Failure Scenarios
       }
       """
 
+  Scenario: Invalid category for type
+    Given the application 'DataShare' (ID 'z00z-y11y-x22x') is registered to access the API
+    And the organisation 'X26' is authorised to access pointer types:
+      | system                 | value            |
+      | http://snomed.info/sct | 1363501000000100 |
+      | http://snomed.info/sct | 736253002        |
+    When producer 'X26' creates a DocumentReference with values:
+      | property  | value                          |
+      | subject   | 9999999999                     |
+      | status    | current                        |
+      | type      | 736253002                      |
+      | category  | 1102421000000108               |
+      | custodian | X26                            |
+      | author    | HAR1                           |
+      | url       | https://example.org/my-doc.pdf |
+    Then the response status code is 400
+    And the response is an OperationOutcome with 1 issue
+    And the OperationOutcome contains the issue:
+      """
+      {
+        "severity": "error",
+        "code": "invalid",
+        "details": {
+        "coding": [
+        {
+        "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+        "code": "BAD_REQUEST",
+        "display": "Bad request"
+        }
+        ]
+        },
+        "diagnostics": "The Category code of the provided document 'http://snomed.info/sct|1102421000000108' must match the allowed category for pointer type 'http://snomed.info/sct|736253002' with a category value of 'http://snomed.info/sct|734163000'",
+        "expression": [
+        "category.coding[0].code"
+        ]
+      }
+      """
+
 # Invalid document reference - invalid Type
 # NRL-769 Known issue: Type display is not validated
 # Scenario: Invalid type (valid code but wrong display value)

tests/features/producer/upsertDocumentReference-failure.feature

@@ -0,0 +1,40 @@
+Feature: Producer - upsertDocumentReference - Failure Scenarios
+
+  Scenario: Invalid category for type
+    Given the application 'DataShare' (ID 'z00z-y11y-x22x') is registered to access the API
+    And the organisation 'X26' is authorised to access pointer types:
+      | system                 | value            |
+      | http://snomed.info/sct | 1363501000000100 |
+      | http://snomed.info/sct | 736253002        |
+    When producer 'X26' upserts a DocumentReference with values:
+      | property  | value                          |
+      | id        | X26-testid-upsert-0001-0001    |
+      | subject   | 9999999999                     |
+      | status    | current                        |
+      | type      | 736253002                      |
+      | category  | 1102421000000108               |
+      | custodian | X26                            |
+      | author    | HAR1                           |
+      | url       | https://example.org/my-doc.pdf |
+    Then the response status code is 400
+    And the response is an OperationOutcome with 1 issue
+    And the OperationOutcome contains the issue:
+      """
+      {
+        "severity": "error",
+        "code": "invalid",
+        "details": {
+        "coding": [
+        {
+        "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+        "code": "BAD_REQUEST",
+        "display": "Bad request"
+        }
+        ]
+        },
+        "diagnostics": "The Category code of the provided document 'http://snomed.info/sct|1102421000000108' must match the allowed category for pointer type 'http://snomed.info/sct|736253002' with a category value of 'http://snomed.info/sct|734163000'",
+        "expression": [
+        "category.coding[0].code"
+        ]
+      }
+      """