NRL-518 Move content fhir url strings to constants

Author: axelkrastek1-nhs

layer/nrlf/core/constants.py

@@ -185,3 +185,10 @@ def coding_value(self):
 
 
 SYSTEM_SHORT_IDS = {"http://snomed.info/sct": "SCT", "https://nicip.nhs.uk": "NICIP"}
+CONTENT_STABILITY_EXTENSION_URL = (
+    "https://fhir.nhs.uk/England/StructureDefinition/Extension-England-ContentStability"
+)
+CONTENT_STABILITY_SYSTEM_URL = (
+    "https://fhir.nhs.uk/England/CodeSystem/England-NRLContentStability"
+)
+CONTENT_FORMAT_CODE_URL = "https://fhir.nhs.uk/England/CodeSystem/England-NRLFormatCode"

layer/nrlf/core/errors.py

@@ -3,6 +3,7 @@
 from pydantic import ValidationError
 from pydantic_core import ErrorDetails
 
+from nrlf.core.constants import CONTENT_FORMAT_CODE_URL, CONTENT_STABILITY_SYSTEM_URL
 from nrlf.core.response import Response
 from nrlf.core.types import CodeableConcept
 from nrlf.producer.fhir.r4 import model as producer_model
@@ -25,9 +26,9 @@ def append_value_set_url(loc_string: str) -> str:
 
     if "content" in loc_string:
         if "extension" in loc_string:
-            return ". See ValueSet: https://fhir.nhs.uk/England/CodeSystem/England-NRLContentStability"
+            return f". See ValueSet: {CONTENT_STABILITY_SYSTEM_URL}"
         if "format" in loc_string:
-            return ". See ValueSet: https://fhir.nhs.uk/England/CodeSystem/England-NRLFormatCode"
+            return f". See ValueSet: {CONTENT_FORMAT_CODE_URL}"
 
     return ""
 

tests/features/utils/data.py

@@ -1,4 +1,10 @@
-from layer.nrlf.core.constants import CATEGORY_ATTRIBUTES, TYPE_ATTRIBUTES
+from layer.nrlf.core.constants import (
+    CATEGORY_ATTRIBUTES,
+    CONTENT_FORMAT_CODE_URL,
+    CONTENT_STABILITY_EXTENSION_URL,
+    CONTENT_STABILITY_SYSTEM_URL,
+    TYPE_ATTRIBUTES,
+)
 from nrlf.producer.fhir.r4.model import (
     Attachment,
     CodeableConcept,
@@ -43,18 +49,18 @@ def create_test_document_reference(items: dict) -> DocumentReference:
                     format=NRLFormatCode(
                         system=items.get(
                             "formatSystem",
-                            "https://fhir.nhs.uk/England/CodeSystem/England-NRLFormatCode",
+                            CONTENT_FORMAT_CODE_URL,
                         ),
                         code=items.get("formatCode", "urn:nhs-ic:unstructured"),
                         display=items.get("formatDisplay", "Unstructured Document"),
                     ),
                     extension=[
                         ContentStabilityExtension(
-                            url="https://fhir.nhs.uk/England/StructureDefinition/Extension-England-ContentStability",
+                            url=CONTENT_STABILITY_EXTENSION_URL,
                             valueCodeableConcept=ContentStabilityExtensionValueCodeableConcept(
                                 coding=[
                                     ContentStabilityExtensionCoding(
-                                        system="https://fhir.nhs.uk/England/CodeSystem/England-NRLContentStability",
+                                        system=CONTENT_STABILITY_SYSTEM_URL,
                                         code="static",
                                         display="Static",
                                     )

tests/smoke/setup.py

@@ -1,4 +1,11 @@
-from nrlf.core.constants import TYPE_ATTRIBUTES, Categories, PointerTypes
+from nrlf.core.constants import (
+    CONTENT_FORMAT_CODE_URL,
+    CONTENT_STABILITY_EXTENSION_URL,
+    CONTENT_STABILITY_SYSTEM_URL,
+    TYPE_ATTRIBUTES,
+    Categories,
+    PointerTypes,
+)
 from nrlf.producer.fhir.r4.model import (
     Attachment,
     CodeableConcept,
@@ -37,17 +44,17 @@ def build_document_reference(
                     url=content_url,
                 ),
                 format=NRLFormatCode(
-                    system="https://fhir.nhs.uk/England/CodeSystem/England-NRLFormatCode",
+                    system=CONTENT_FORMAT_CODE_URL,
                     code="urn:nhs-ic:unstructured",
                     display="Unstructured Document",
                 ),
                 extension=[
                     ContentStabilityExtension(
-                        url="https://fhir.nhs.uk/England/StructureDefinition/Extension-England-ContentStability",
+                        url=CONTENT_STABILITY_EXTENSION_URL,
                         valueCodeableConcept=ContentStabilityExtensionValueCodeableConcept(
                             coding=[
                                 ContentStabilityExtensionCoding(
-                                    system="https://fhir.nhs.uk/England/CodeSystem/England-NRLContentStability",
+                                    system=CONTENT_STABILITY_SYSTEM_URL,
                                     code="static",
                                     display="Static",
                                 )