NRL-478 update error message from pydantic to get all of location

Author: eesa456

api/producer/createDocumentReference/tests/test_create_document_reference.py

@@ -369,6 +369,47 @@ def test_create_document_reference_with_no_custodian():
     }
 
 
+def test_create_document_reference_with_no_practiceSetting():
+    doc_ref = load_document_reference("Y05868-736253002-Valid")
+    doc_ref.context.practiceSetting = None
+
+    event = create_test_api_gateway_event(
+        headers=create_headers(),
+        body=doc_ref.model_dump_json(exclude_none=True),
+    )
+
+    result = handler(event, create_mock_context())
+    body = result.pop("body")
+
+    assert result == {
+        "statusCode": "400",
+        "headers": default_response_headers(),
+        "isBase64Encoded": False,
+    }
+
+    parsed_body = json.loads(body)
+    assert parsed_body == {
+        "resourceType": "OperationOutcome",
+        "issue": [
+            {
+                "severity": "error",
+                "code": "invalid",
+                "details": {
+                    "coding": [
+                        {
+                            "code": "MESSAGE_NOT_WELL_FORMED",
+                            "display": "Message not well formed",
+                            "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+                        }
+                    ],
+                },
+                "diagnostics": "Request body could not be parsed (context.practiceSetting: Field required)",
+                "expression": ["context.practiceSetting"],
+            },
+        ],
+    }
+
+
 def test_create_document_reference_invalid_custodian_id():
     doc_ref = load_document_reference("Y05868-736253002-Valid")
 

api/producer/updateDocumentReference/tests/test_update_document_reference.py

@@ -295,6 +295,47 @@ def test_create_document_reference_invalid_body():
     }
 
 
+def test_update_document_reference_with_no_practiceSetting():
+    doc_ref = load_document_reference("Y05868-736253002-Valid")
+    doc_ref.context.practiceSetting = None
+
+    event = create_test_api_gateway_event(
+        headers=create_headers(),
+        body=doc_ref.model_dump_json(exclude_none=True),
+    )
+
+    result = handler(event, create_mock_context())
+    body = result.pop("body")
+
+    assert result == {
+        "statusCode": "400",
+        "headers": default_response_headers(),
+        "isBase64Encoded": False,
+    }
+
+    parsed_body = json.loads(body)
+    assert parsed_body == {
+        "resourceType": "OperationOutcome",
+        "issue": [
+            {
+                "severity": "error",
+                "code": "invalid",
+                "details": {
+                    "coding": [
+                        {
+                            "code": "MESSAGE_NOT_WELL_FORMED",
+                            "display": "Message not well formed",
+                            "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+                        }
+                    ],
+                },
+                "diagnostics": "Request body could not be parsed (context.practiceSetting: Field required)",
+                "expression": ["context.practiceSetting"],
+            },
+        ],
+    }
+
+
 def test_update_document_reference_no_id_in_path():
     doc_ref = load_document_reference("Y05868-736253002-Valid")
     event = create_test_api_gateway_event(

api/producer/upsertDocumentReference/tests/test_upsert_document_reference.py

@@ -413,6 +413,47 @@ def test_upsert_document_reference_invalid_resource():
     }
 
 
+def test_upsert_document_reference_with_no_practiceSetting():
+    doc_ref = load_document_reference("Y05868-736253002-Valid")
+    doc_ref.context.practiceSetting = None
+
+    event = create_test_api_gateway_event(
+        headers=create_headers(),
+        body=doc_ref.model_dump_json(exclude_none=True),
+    )
+
+    result = handler(event, create_mock_context())
+    body = result.pop("body")
+
+    assert result == {
+        "statusCode": "400",
+        "headers": default_response_headers(),
+        "isBase64Encoded": False,
+    }
+
+    parsed_body = json.loads(body)
+    assert parsed_body == {
+        "resourceType": "OperationOutcome",
+        "issue": [
+            {
+                "severity": "error",
+                "code": "invalid",
+                "details": {
+                    "coding": [
+                        {
+                            "code": "MESSAGE_NOT_WELL_FORMED",
+                            "display": "Message not well formed",
+                            "system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
+                        }
+                    ],
+                },
+                "diagnostics": "Request body could not be parsed (context.practiceSetting: Field required)",
+                "expression": ["context.practiceSetting"],
+            },
+        ],
+    }
+
+
 def test_upsert_document_reference_invalid_producer_id():
     doc_ref = load_document_reference("Y05868-736253002-Valid")
     doc_ref.id = "X26-99999-99999-999999"

layer/nrlf/core/errors.py

@@ -11,13 +11,14 @@
 
 def diag_for_error(error: ErrorDetails) -> str:
     if error["loc"]:
-        return f"{error['loc'][0]}: {error['msg']}"
+        loc_string = ".".join(each for each in error["loc"])
+        return f"{loc_string}: {error['msg']}"
     else:
         return f"root: {error['msg']}"
 
 
 def expression_for_error(error: ErrorDetails) -> Optional[str]:
-    return str(error["loc"][0] if error["loc"] else "root")
+    return str(".".join(each for each in error["loc"]) if error["loc"] else "root")
 
 
 class OperationOutcomeError(Exception):