NRL-1385 create key pair to rdp into ec2

Author: jackleary

terraform/account-wide-infrastructure/dev/ec2.tf

@@ -11,7 +11,6 @@ module "vpc" {
 module "web" {
   source        = "../modules/ec2"
   instance_type = var.instance_type
-  instance_key  = var.instance_key
   name_prefix   = "nhsd-nrlf--dev"
 
   subnet_id       = module.vpc.subnet_id

terraform/account-wide-infrastructure/dev/vars.tf

@@ -43,7 +43,3 @@ variable "instance_type" {
   description = "Type for EC2 Instance"
   default     = "t2.micro"
 }
-
-variable "instance_key" {
-  default = "PowerBIGateway"
-}

terraform/account-wide-infrastructure/modules/ec2/ec2.tf

@@ -2,7 +2,7 @@
 resource "aws_instance" "web" {
   ami             = data.aws_ami.windows-2019.id
   instance_type   = var.instance_type
-  key_name        = var.instance_key
+  key_name        = aws_key_pair.ec2_key_pair.key_name
   subnet_id       = var.subnet_id
   security_groups = var.security_groups
 
@@ -13,3 +13,19 @@ resource "aws_instance" "web" {
   }
 
 }
+
+# Key pair for RDP access
+resource "tls_private_key" "instance_key_pair" {
+  algorithm = "RSA"
+}
+
+resource "aws_key_pair" "ec2_key_pair" {
+  key_name   = "PowerBI-GateWay-Key"
+  public_key = tls_private_key.instance_key_pair.public_key_openssh
+}
+
+# Saving Key Pair for ssh login for Client if needed
+resource "local_file" "ssh_key" {
+  filename = "${aws_key_pair.ec2_key_pair.key_name}.pem"
+  content  = tls_private_key.instance_key_pair.private_key_pem
+}

terraform/account-wide-infrastructure/modules/ec2/vars.tf

@@ -3,6 +3,5 @@ variable "name_prefix" {
   description = "The prefix to apply to all resources in the module."
 }
 variable "instance_type" {}
-variable "instance_key" {}
 variable "security_groups" {}
 variable "subnet_id" {}