Merge pull request #823 from NHSDigital/bug/jale13-fix-dev-sandbox-infra

Dev sandbox bugfix

Author: jackleary

terraform/infrastructure/locals.tf

@@ -29,9 +29,9 @@ locals {
   public_domain = local.is_sandbox_env ? var.public_sandbox_domain : var.public_domain
 
   # Logic / vars for reporting
-  reporting_bucket_arn = local.is_dev_env ? data.aws_s3_bucket.source-data-bucket[0].arn : null
-  reporting_kms_arn    = local.is_dev_env ? data.aws_kms_key.glue[0].arn : null
-  firehose_lambda_subscriptions = local.is_dev_env ? [
+  reporting_bucket_arn = local.is_dev_env && !local.is_sandbox_env ? data.aws_s3_bucket.source-data-bucket[0].arn : null
+  reporting_kms_arn    = local.is_dev_env && !local.is_sandbox_env ? data.aws_kms_key.glue[0].arn : null
+  firehose_lambda_subscriptions = local.is_dev_env && !local.is_sandbox_env ? [
     module.firehose__processor.firehose_subscription,
     module.firehose__processor.firehose_reporting_subscription
     ] : [