NRL-518 Simplify test, fix lint warnings

Author: axelkrastek1-nhs

layer/nrlf/core/tests/test_pydantic_errors.py

@@ -1,9 +1,12 @@
 from unittest.mock import Mock
+
 import pytest
+
 from nrlf.core.errors import ParseError
 from nrlf.core.validators import DocumentReferenceValidator
 from nrlf.tests.data import load_document_reference_json
 
+
 def test_validate_content_missing_attachment():
     validator = DocumentReferenceValidator()
     document_ref_data = load_document_reference_json("Y05868-736253002-Valid")
@@ -31,6 +34,7 @@ def test_validate_content_missing_attachment():
         "expression": ["content.0.attachment"],
     }
 
+
 def test_validate_content_missing_content_type():
     validator = DocumentReferenceValidator()
     document_ref_data = load_document_reference_json("Y05868-736253002-Valid")
@@ -58,6 +62,7 @@ def test_validate_content_missing_content_type():
         "expression": ["content.0.attachment.contentType"],
     }
 
+
 def test_validate_content_invalid_content_type():
     validator = DocumentReferenceValidator()
     document_ref_data = load_document_reference_json("Y05868-736253002-Valid")

layer/nrlf/core/tests/test_validators.py

@@ -960,18 +960,8 @@ def test_validate_content_extension_invalid_code():
     validator = DocumentReferenceValidator()
     document_ref_data = load_document_reference_json("Y05868-736253002-Valid")
 
-    document_ref_data["content"][0]["extension"][0] = {
-        "url": "https://fhir.nhs.uk/England/StructureDefinition/Extension-England-ContentStability",
-        "valueCodeableConcept": {
-            "coding": [
-                {
-                    "system": "https://fhir.nhs.uk/England/CodeSystem/England-NRLContentStability",
-                    "code": "invalid",
-                    "display": "invalid",
-                }
-            ]
-        },
-    }
+    content_extension = document_ref_data["content"][0]["extension"][0]
+    content_extension["valueCodeableConcept"]["coding"][0]["code"] = "invalid"
 
     result = validator.validate(document_ref_data)
 
@@ -1523,6 +1513,7 @@ def test_validate_ssp_content_with_multiple_asids():
         "expression": ["context.related"],
     }
 
+
 def test_validate_content_extension_invalid_code_and_display_mismatch():
     validator = DocumentReferenceValidator()
     document_ref_data = load_document_reference_json("Y05868-736253002-Valid")