[NRL-853] Remove incorrect optional. Remove unused cold_storage_after

Author: mattdean3-nhs

terraform/account-wide-infrastructure/modules/backup-source/backup_plan.tf

@@ -20,8 +20,7 @@ resource "aws_backup_plan" "default" {
         for_each = rule.value.copy_action
         content {
           lifecycle {
-            delete_after       = copy_action.value.delete_after
-            cold_storage_after = copy_action.value.cold_storage_after
+            delete_after = copy_action.value.delete_after
           }
           destination_vault_arn = var.backup_copy_vault_arn
         }

terraform/account-wide-infrastructure/modules/backup-source/variables.tf

@@ -78,7 +78,7 @@ variable "backup_plan_config" {
     enable                    = bool
     selection_tag             = string
     compliance_resource_types = list(string)
-    rules = optional(list(object({
+    rules = list(object({
       name                     = string
       schedule                 = string
       enable_continuous_backup = optional(bool)
@@ -90,7 +90,7 @@ variable "backup_plan_config" {
         delete_after       = optional(number)
         cold_storage_after = optional(number)
       })))
-    })))
+    }))
   })
 }
 variable "backup_plan_config_dynamodb" {