NRL-1188 Pass s3 bucket arn as var

jackleary · jackleary · commit fa711eb12563 · 2024-12-17T08:20:35.000Z
diff --git a/terraform/infrastructure/firehose.tf b/terraform/infrastructure/firehose.tf
@@ -8,4 +8,5 @@ module "firehose__processor" {
   splunk_environment = local.splunk_environment
   splunk_index       = local.splunk_index
   destination        = "splunk"
+  reporting_bucket   = data.aws_s3_bucket.source-data-bucket.arn
 }
diff --git a/terraform/infrastructure/modules/firehose/kinesis.tf b/terraform/infrastructure/modules/firehose/kinesis.tf
@@ -63,7 +63,7 @@ resource "aws_kinesis_firehose_delivery_stream" "reporting_stream" {
 
   extended_s3_configuration {
     role_arn   = aws_iam_role.firehose.arn
-    bucket_arn = data.aws_s3_bucket.source-data-bucket.arn
+    bucket_arn = var.reporting_bucket
 
     processing_configuration {
       enabled = "true"

Original file line number	Diff line number	Diff line change
`@@ -8,4 +8,5 @@ module "firehose__processor" {`
`8`	`8`	`splunk_environment = local.splunk_environment`
`9`	`9`	`splunk_index = local.splunk_index`
`10`	`10`	`destination = "splunk"`
	`11`	`+ reporting_bucket = data.aws_s3_bucket.source-data-bucket.arn`
`11`	`12`	`}`