NRL-1595 Bot suggestions + amendments from self-review

Author: atrace

.github/workflows/deploy-account-wide-infra.yml

@@ -31,6 +31,7 @@ jobs:
           if [[ $IS_VALID_ENV == true ]]; then
             exit 0
           fi
+          echo "This workflow can only be run with 'account-*' environments as it deploys account-specific infrastructure"
           exit 1
 
   terraform-plan:

scripts/get-envs-for-account.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
-# Get the name of all environments in a provided NRLF account
+# Get the names of all environments in a provided NRL AWS account
 set -o errexit -o nounset -o pipefail
 
-if [ $# -ne 1 ]; then
+if [[ $# -ne 1 ]]; then
     echo "Usage: get-envs-for-account.sh <account>"
     exit 1
 fi
@@ -11,11 +11,11 @@ account="$1"
 
 case "${account}" in
     dev)
-        envs_array=("dev") # "dev-sandbox")
+        envs_array=("dev" "dev-sandbox")
         echo ${envs_array[@]}
         ;;
     test)
-        envs_array=("qa" "perftest" "ref" "int") # "int-sandbox" "qa-sandbox") - I don't have perms for these!
+        envs_array=("qa" "perftest" "ref" "int" "int-sandbox") #  "qa-sandbox" currently broken
         echo ${envs_array[@]}
         ;;
     prod)