Skip to content

Commit 08be9ab

Browse files
As per PR# 107 comments, code change is implemented.
1 parent c828002 commit 08be9ab

File tree

1 file changed

+10
-18
lines changed

1 file changed

+10
-18
lines changed

utils/oracle/subject_selection_query_builder.py

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -963,25 +963,17 @@ def _add_criteria_event_status(self, column_name: str) -> None:
963963
and injects its corresponding event_status_id into SQL.
964964
"""
965965
try:
966-
# Extract the code (e.g. "ES01") from the first word
967-
code = self.criteria_value.strip().split()[0].upper()
968-
comparator = self.criteria_comparator
969-
970-
# Simulated EventStatusType registry
971-
event_status_code_map = {
972-
"ES01": 600,
973-
"ES02": 601,
974-
"ES03": 602,
975-
"ES99": 699,
976-
# ...update with real mappings
977-
}
978-
979-
if code not in event_status_code_map:
980-
raise ValueError(f"Unknown event status code: {code}")
981-
982-
event_status_id = event_status_code_map[code]
983-
self.sql_where.append(f"AND {column_name} {comparator} {event_status_id}")
966+
self._add_join_to_latest_episode()
967+
criteria_words = self.criteria_value.split(" ")
968+
event_status = EventStatusType.get_by_code(criteria_words[0].upper())
969+
if event_status is None:
970+
raise SelectionBuilderException(
971+
self.criteria_key_name, self.criteria_value
972+
)
984973

974+
self.sql_where.append(
975+
f" AND {column_name} {self.criteria_comparator} {int(event_status.id) }"
976+
)
985977
except Exception:
986978
raise SelectionBuilderException(self.criteria_key_name, self.criteria_value)
987979

0 commit comments

Comments
 (0)