Removed secrets and used .env file to pass these in

Added users to users.json

Author: Andyg79

pages/login_page.py

@@ -1,5 +1,8 @@
-from playwright.sync_api import Page
+import os
 
+from playwright.sync_api import Page
+from utils.user_tools import UserTools
+from dotenv import load_dotenv
 
 class BcssLoginPage:
 
@@ -23,6 +26,26 @@ def login(self, username, password):
 
     def login_as_user_bcss401(self):
         """Logs in to bcss as the test user 'BCSS401'"""
-        self.username.fill("BCSS401")
-        self.password.fill("changeme")
+        # Take environment variables from .env
+        load_dotenv()
+        # Retrieve and enter username from users.json
+        user_details = UserTools.retrieve_user("BCSS401")
+        self.username.fill(user_details["username"])
+        # Retrieve and enter password from .env file
+        password = os.getenv("BCSS_PASS")
+        self.password.fill(password)
+        # Click submit button
+        self.submit_button.click()
+
+    def login_as_user_bcss118(self):
+        """Logs in to bcss as the test user 'BCSS118'"""
+        # Take environment variables from .env
+        load_dotenv()
+        # Retrieve and enter username from users.json
+        user_details = UserTools.retrieve_user("BCSS118")
+        self.username.fill(user_details["username"])
+        # Retrieve and enter password from .env file
+        password = os.getenv("BCSS_PASS")
+        self.password.fill(password)
+        # Click submit button
         self.submit_button.click()

requirements.txt

@@ -1,3 +1,9 @@
 pytest-playwright>=0.5.1
 pytest-html>=4.1.1
 pytest-json-report>=1.5.0
+
+playwright~=1.47.0
+dotenv~=0.9.9
+python-dotenv~=1.0.1
+pytest~=8.3.3
+Flask~=3.0.3

tests/test_login_to_bcss.py

@@ -1,3 +1,6 @@
+import os
+
+from dotenv import load_dotenv
 from playwright.sync_api import Page, expect
 from pages.login_page import BcssLoginPage
 
@@ -16,9 +19,13 @@ def test_login_to_bcss_with_invalid_username(page: Page) -> None:
     """
     Confirms that a user with a valid password, and invalid username, can NOT log in to bcss
     """
-    # Enter a valid password with an invalid username and click 'sign in' button
+    # Take environment variables from .env
+    load_dotenv()
+    # Set an invalid username
     username = "BCSSZZZ"
-    password = "changeme"
+    # Retrieve valid password from .env file
+    password = os.getenv("BCSS_PASS")
+    # Enter valid password with an invalid username and click 'sign in' button
     BcssLoginPage(page).login(username, password)
     # Confirm error message is displayed
     expect(page.locator("body")).to_contain_text("Incorrect username or password.")

users.json

@@ -1,11 +1,16 @@
 {
-    "_comment": "This file can be used to store data on users for your application, and then pulled through using the utils.user_tools UserTools utility. The documentation for this utility explains how this file is read.",
-    "Example User 1": {
-        "username": "EXAMPLE_USER1",
-        "roles": ["Example Role A"]
-    },
-    "Example User 2": {
-        "username": "EXAMPLE_USER2",
-        "roles": ["Example Role B", "Example Role C"]
-    }
+  "_comment": "This file can be used to store data on users for your application, and then pulled through using the utils.user_tools UserTools utility. The documentation for this utility explains how this file is read.",
+
+  "BCSS401": {
+    "username": "BCSS401",
+    "roles": [
+      "Hub Manager State Registered, Midlands and North West"
+    ]
+  },
+  "BCSS118": {
+    "username": "BCSS118",
+    "roles": [
+      "Screening Centre Manager for Wolverhampton, Midlands and North West"
+    ]
+  }
 }