Addressing PR comments

Author: adrianoaru-nhs

pages/screening_subject_search/advance_fobt_screening_episode_page.py

@@ -96,9 +96,6 @@ def __init__(self, page: Page):
         self.redirect_to_reestablish_suitability_for_diagnostic_test_repatient_contact = self.page.get_by_role(
             "button", name="Redirect to re-establish"
         )
-        self.invite_for_diagnostic_test_button = self.page.get_by_role(
-            "button", name="Invite for Diagnostic Test >>"
-        )
         self.mdt_referral_required_button = self.page.get_by_role(
             "button", name="MDT Referral Required"
         )

pages/screening_subject_search/non_neoplastic_result_from_symptomatic_procedure_page.py

@@ -9,7 +9,6 @@ class NonNeoplasticResultFromSymptomaticProcedurePage(BasePage):
 
     def __init__(self, page: Page):
         super().__init__(page)
-        self.page = page
         # Non Neoplastic Result From Symptomatic Procedure - page locators
         self.date_of_symptomatic_procedure_calendar_button = self.page.locator(
             "#UI_SURGERY_DATE__LinkOrButton"
@@ -46,7 +45,7 @@ def select_test_number(self, test_number: int) -> None:
         """
         Select a test from the all tests dropdown by its index.
         Args:
-            test_number (int): The index of the test to select (1-based index). Example: 1
+            test_number (int): The index of the test to select (1-based index). Example: if you want to select the 1st test pass in 1
         """
         self.click(self.all_tests.nth(test_number - 1))
 

pages/screening_subject_search/return_from_symptomatic_referral_page.py

@@ -7,7 +7,6 @@ class ReturnFromSymptomaticReferralPage(BasePage):
 
     def __init__(self, page: Page):
         super().__init__(page)
-        self.page = page
         # Return From Symptomatic Referral - page locators
         self.radiological_or_endoscopic_referral_dropdown = self.page.locator(
             "#referralTypeId"

pages/screening_subject_search/subject_demographic_page.py

@@ -140,7 +140,6 @@ def handle_dialog(dialog: Dialog):
             Handles the dialog and asserts that the dialog contains the expected text.
             Args:
                 dialog (Dialog): the playwright dialog object
-                accept (bool): Set to True if you want to accept the dialog, by default is is set to False.
             """
             logging.info(f"Dialog appeared with message: {dialog.message}")
             actual_text = dialog.message

utils/subject_demographics.py

@@ -114,19 +114,21 @@ def updated_subject_demographics(
         Navigates to the subject demographics page and updates a subject's demographics.
         Args:
             nhs_no (str): The NHS number of the subject you want to update.
-            date_of_birth (Optional[datetime]): The new date of birth to set for the subject.
-            postcode (Optional[str]): The new postcode to set for the subject.
+            age (int): The aage the subject should be updated to.
+            postcode (str): The new postcode of the subject.
+            dialog_text (str): The dialog text to assert
         """
+        subject_screening_page = SubjectScreeningPage(self.page)
         BasePage(self.page).click_main_menu_link()
         BasePage(self.page).go_to_screening_subject_search_page()
-        SubjectScreeningPage(self.page).click_demographics_filter()
-        SubjectScreeningPage(self.page).click_nhs_number_filter()
-        SubjectScreeningPage(self.page).nhs_number_filter.fill(nhs_no)
-        SubjectScreeningPage(self.page).nhs_number_filter.press("Tab")
-        SubjectScreeningPage(self.page).select_search_area_option(
+        subject_screening_page.click_demographics_filter()
+        subject_screening_page.click_nhs_number_filter()
+        subject_screening_page.nhs_number_filter.fill(nhs_no)
+        subject_screening_page.nhs_number_filter.press("Tab")
+        subject_screening_page.select_search_area_option(
             SearchAreaSearchOptions.SEARCH_AREA_WHOLE_DATABASE.value
         )
-        SubjectScreeningPage(self.page).click_search_button()
+        subject_screening_page.click_search_button()
         if postcode:
             SubjectDemographicPage(self.page).fill_postcode_input(postcode)
         if age: